Page MenuHome

VSE: Hide 2D cusror when not selected as pivot
Changes PlannedPublic

Authored by Richard Antalik (ISS) on Oct 19 2021, 4:48 AM.

Details

Summary

Minimize visual noise by hiding 2D cursor when not selected as pivot
point.

Diff Detail

Repository
rB Blender
Branch
master
Build Status
Buildable 17978
Build 17978: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 19 2021, 4:48 AM
Richard Antalik (ISS) created this revision.

Maybe the 2d cursor tool button should be removed from the toolbar when not in use?

Campbell Barton (campbellbarton) requested changes to this revision.EditedOct 19 2021, 4:02 PM

This won't work well in a few cases.

  • When the cursor is used more (snap menu's snap to/from cursor for example).
  • When the cursor tool is active.
  • When transforming the cursor.

Why not have an overlay option? Then the cursor can be on/off or depend on pivot?

This revision now requires changes to proceed.Oct 19 2021, 4:02 PM

This won't work well in a few cases.

  • When the cursor is used more (snap menu's snap to/from cursor for example).
  • When the cursor tool is active.
  • When transforming the cursor.

Why not have an overlay option? Then the cursor can be on/off or depend on pivot?

I guess this would work, I later realized there will be issues like this too. I mostly wanted to point out, that 2D cursor would be used quite rarely and it should not be visible by default.
Then question is, whether it is better to have simple on/off option or option to auto hide. I would probably prefer simple on/off switch, because not all operations that use 2D cursor are modal. So I will make patch for that.

This may be still useful feature perhaps, so I can update it for more use-cases but it will have to be maintained when new features are added. Sounds like it would be best if there was flag in SpaceSeq that would indicate if 2D cursor is "in use".

Richard Antalik (ISS) planned changes to this revision.Oct 20 2021, 1:00 AM

I'll post here too, then: Imo, some more "intelligence" should be build into this. Right now the 2d cursor tool is visible when the tool is not. This will lead to confusion. Either both should be switched on/off with the overlay checkbox, or the 2d cursor should be automatically switched on when the tool is active, and automatically switched off when the tool isn't selected + pivot is not 2d cursor (+ snap to 2d cursor(if that is ever going to be implemented)) - but can be manually switched one in the Overlay settings.

NB. letting one setting determine another setting is not a completely otherworldly ex. Zoom to Fit is automatically disabled when resolution is manually changed.