Details

Reviewers

Manuel Castilla (manzanilla)
Dalai Felinto (dfelinto)

Maniphest Tasks

T95385: Compositor: Combine and Separate XYZ

Commits

rB9cc4861e6f7d: Compositor: Combine and Separate XYZ Node

Summary

We have this node for shader and geometry nodes. Compositor can also
work with vectors, and this can help with that.

Diff Detail

Repository

rB Blender

Branch

compositor-xyz-separate-combine (branched from master)

Build Status

Buildable 18002
Build 18002: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Oct 19 2021, 11:46 AM

Dalai Felinto (dfelinto) created this revision.

Harbormaster completed remote builds in B17986: Diff 43554.Oct 19 2021, 11:46 AM

Cleanup: Bring back empty line

Harbormaster completed remote builds in B17987: Diff 43555.Oct 19 2021, 11:48 AM

Looks good to me. I think it can be useful too. Even if it can be done with separate/combine RGBA, users might not be aware of it and with this it has the proper socket fields.

source/blender/nodes/composite/nodes/node_composite_sepcombXYZ.cc
17	year -> 2021

This revision is now accepted and ready to land.Oct 19 2021, 1:48 PM

From review: fix copyright year

Harbormaster completed remote builds in B18002: Diff 43572.Oct 19 2021, 3:08 PM

Thanks, I will commit it once we get to bcon1 again.

Dalai Felinto (dfelinto) added a project: BF Blender (3.1).Oct 19 2021, 3:08 PM

Raimund Klink (Raimund58) added a subscriber: Raimund Klink (Raimund58).Feb 1 2022, 11:59 AM

Raimund Klink (Raimund58) mentioned this in T95385: Compositor: Combine and Separate XYZ.Feb 1 2022, 12:12 PM

Raimund Klink (Raimund58) added a task: T95385: Compositor: Combine and Separate XYZ.

Aaron Carlisle (Blendify) commandeered this revision.Feb 1 2022, 11:46 PM

Aaron Carlisle (Blendify) added a reviewer: Dalai Felinto (dfelinto).

Merge branch 'master' into arcpatch-D12919

Harbormaster completed remote builds in B20285: Diff 47846.Feb 2 2022, 12:15 AM

Closed by commit rB9cc4861e6f7d: Compositor: Combine and Separate XYZ Node (authored by Aaron Carlisle (Blendify)). · Explain WhyFeb 2 2022, 12:19 AM

This revision was automatically updated to reflect the committed changes.

Aaron Carlisle (Blendify) added a commit: rB9cc4861e6f7d: Compositor: Combine and Separate XYZ Node.

Compositor: Combine and Separate XYZ
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 43572

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/compositor/CMakeLists.txt

source/blender/compositor/intern/COM_Converter.cc

source/blender/compositor/nodes/COM_CombineXYZNode.h

source/blender/compositor/nodes/COM_CombineXYZNode.cc

source/blender/compositor/nodes/COM_SeparateXYZNode.h

source/blender/compositor/nodes/COM_SeparateXYZNode.cc

source/blender/makesrna/RNA_access.h

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_composite.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/composite/nodes/node_composite_sepcombXYZ.cc

Compositor: Combine and Separate XYZClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 43572

release/scripts/startup/nodeitems_builtins.py

source/blender/blenkernel/BKE_node.h

source/blender/blenkernel/intern/node.cc

source/blender/compositor/CMakeLists.txt

source/blender/compositor/intern/COM_Converter.cc

source/blender/compositor/nodes/COM_CombineXYZNode.h

source/blender/compositor/nodes/COM_CombineXYZNode.cc

source/blender/compositor/nodes/COM_SeparateXYZNode.h

source/blender/compositor/nodes/COM_SeparateXYZNode.cc

source/blender/makesrna/RNA_access.h

source/blender/nodes/CMakeLists.txt

source/blender/nodes/NOD_composite.h

source/blender/nodes/NOD_static_types.h

source/blender/nodes/composite/nodes/node_composite_sepcombXYZ.cc

Compositor: Combine and Separate XYZ
ClosedPublic
Actions

Revision Contents
Changeset List