Page MenuHome
Differential D12920

Cleanup: More readable Cycles OSL BSDF definition
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Oct 19 2021, 11:49 AM.

Details

Reviewers
Brecht Van Lommel (brecht)
Commits
rC5db020015184: Cleanup: More readable Cycles OSL BSDF definition
rB765eba5a6e03: Cleanup: More readable Cycles OSL BSDF definition
Summary

A Clang-Format configuration to make the closure definition block to
be properly recognized as such.

Also small wrapper macro to avoid comma in the actual definition code
which was causing unwanted indentation of parameters definition.

Requires Clang-Format 7 or newer. The version we ship in the libs is
12, so for recommended development setup it should all be good.

Diff Detail

Repository
rB Blender
Branch
cycles_osl_clang_format (branched from master)
Build Status
Buildable 17989
Build 17989: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Oct 19 2021, 11:49 AM
Sergey Sharybin (sergey) created this revision.
Harbormaster completed remote builds in B17988: Diff 43556.Oct 19 2021, 11:49 AM
Sergey Sharybin (sergey) updated this revision to Diff 43557.Oct 19 2021, 11:54 AM

Some part of the patch got missing in the first submisison.

Harbormaster completed remote builds in B17989: Diff 43557.Oct 19 2021, 11:54 AM
Brecht Van Lommel (brecht) accepted this revision.Oct 19 2021, 11:56 AM
This revision is now accepted and ready to land.Oct 19 2021, 11:56 AM
Closed by commit rB765eba5a6e03: Cleanup: More readable Cycles OSL BSDF definition (authored by Sergey Sharybin (sergey)). · Explain WhyOct 19 2021, 11:59 AM
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rB765eba5a6e03: Cleanup: More readable Cycles OSL BSDF definition.
Brecht Van Lommel (brecht) added a commit: rC5db020015184: Cleanup: More readable Cycles OSL BSDF definition.Jan 27 2022, 11:30 PM

Revision Contents
Changeset List

PathSize
3 lines
intern/
cycles/
kernel/
osl/
3 lines
254 lines

Diff 43557

View Options

.clang-format

Loading...
View Options

intern/cycles/kernel/osl/osl_closures.h

Loading...
View Options

intern/cycles/kernel/osl/osl_closures.cpp

Loading...