AssetBrowser : Fix Crash when marking assets from python.
ClosedPublic
Actions

Authored by Jeroen Bakker (jbakker) on Oct 19 2021, 1:04 PM.

Details

Reviewers

Sybren A. Stüvel (sybren)
Julian Eisel (Severin)

Maniphest Tasks

T91197: Crash when setting asset preview image from python (ASAN heap-use-after-free in render_preview.c)

Commits

rB1c5722ba071a: Fix T91197: marking assets from Python may crash

Summary

When using asset_mark function from a python script and afterwards updating the preview image,
a crash might happen. The preview image is also generated by the asset_mark function. This could happen
on a background thread, introducing potential synchronization issues.

This patch fixes this by separating the preview generation ID.asset_generate_preview from the mark as
asset ID.asset_mark.

Diff Detail

Repository

rB Blender

Branch

temp-T91197-mark-asset-do-render-preview (branched from master)

Build Status

Buildable 17993
Build 17993: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested review of this revision.Oct 19 2021, 1:04 PM

Jeroen Bakker (jbakker) created this revision.

Harbormaster completed remote builds in B17993: Diff 43563.Oct 19 2021, 1:04 PM

Jeroen Bakker (jbakker) retitled this revision from AssetBrowser : Crash when marking assets from python . to AssetBrowser : Fix Crash when marking assets from python ..Oct 19 2021, 1:09 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added reviewers: Sybren A. Stüvel (sybren), Julian Eisel (Severin).

Jeroen Bakker (jbakker) added projects: Asset Browser, BF Blender (3.0).

Description of the render_preview parameter.

Harbormaster completed remote builds in B17994: Diff 43564.Oct 19 2021, 1:13 PM

Jeroen Bakker (jbakker) retitled this revision from AssetBrowser : Fix Crash when marking assets from python . to AssetBrowser : Fix Crash when marking assets from python..Oct 19 2021, 1:13 PM

Sybren A. Stüvel (sybren) requested changes to this revision.Oct 19 2021, 1:18 PM

Sybren A. Stüvel (sybren) added inline comments.

source/blender/editors/asset/ED_asset_mark_clear.h
37	I really like that this is now independent of the context :)
42	is → might be Whether this is done in a background thread or not depends on the ID type of the asset.
source/blender/makesrna/intern/rna_ID.c
674	Add a negation -- the function should return if it cannot mark as asset, not when it can.