This patch will add the missing Boolean and Integer input.
I've looked mostly at how the Material/Color/Vector input is done.
This is mostly some copy-pasting of existing snippets.
(first patch ever)
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
Thanks for your first patch! Mostly looks good, but some smaller changes are still necessary.
The changes for the bool node also apply to the int node.
| source/blender/blenkernel/intern/node.cc | ||
|---|---|---|
| 5888 | These lines are sorted alphabetically. | |
| source/blender/nodes/NOD_static_types.h | ||
| 282 | These lines are sorted alphabetically. | |
| source/blender/nodes/function/nodes/node_fn_input_bool.cc | ||
| 32 | The namespace should go to right before register_node_type_fn_input_bool. (other files still have to be updated in that regard) | |
| 45 | Remove the blender:: part when the namespace is larger. | |
| 46 | Missing newline. | |
Comment Actions
As Jacques asked:
-changed the order to alphabetical on two files
-changed namespace of the two node function
However, I am not sure if I've done the diff file of this revision correctly.
Comment Actions
Unfortunately you didn't update the diff correctly. Make sure you create a diff between your local branch and master. When you are on your branch do this: git diff master -U1000. The last part adds more context to the diff.
Comment Actions
LGTM.
| source/blender/nodes/function/nodes/node_fn_input_int.cc | ||
|---|---|---|
| 37 | The naming is slightly inconsistent here (input_int vs int_input). | |