Page MenuHome
Differential D12933

VSE: Add 2D cursor overlay option
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Oct 20 2021, 4:16 AM.

Details

Reviewers
Campbell Barton (campbellbarton)
Commits
rB33d6d7c6e33f: VSE: Add 2D cursor overlay option
Summary

Since 2D cursor will be used rarely in VSE and it is adding visual
noise, it will be hidden by default.

D12916 would add feature to reveal 2D cursor when it is actively used.

Diff Detail

Repository
rB Blender
Branch
2d-cursor-overlay (branched from master)
Build Status
Buildable 18025
Build 18025: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Oct 20 2021, 4:16 AM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B18025: Diff 43613.Oct 20 2021, 4:16 AM
Campbell Barton (campbellbarton) added a comment.EditedOct 20 2021, 6:17 AM

Having two ways to adjust the cursor visibility (based on toggle and based on pivot) seems like it could become annoying.

Why not have a single overlay option where the 2D cursor can be:

  • On
  • Off
  • Pivot (when the cursor pivot is enabled).

Then this could be supported for other editors and things can be kept consistent.

Campbell Barton (campbellbarton) accepted this revision.Oct 20 2021, 6:24 AM

Discussed with @Richard Antalik (ISS), we could eventually show the cursor even when off in special cases (when transforming the cursor ... or when the cursor tool is active for example) so this patch LGTM.

This revision is now accepted and ready to land.Oct 20 2021, 6:24 AM
Campbell Barton (campbellbarton) added inline comments.Oct 20 2021, 6:25 AM
source/blender/makesrna/intern/rna_space.c
5431

This can be show_cursor as it's named elsewhere.

Closed by commit rB33d6d7c6e33f: VSE: Add 2D cursor overlay option (authored by Richard Antalik (ISS)). · Explain WhyOct 21 2021, 7:55 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) marked an inline comment as done.
Richard Antalik (ISS) added a commit: rB33d6d7c6e33f: VSE: Add 2D cursor overlay option.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
1 line
source/
blender/
editors/
space_sequencer/
3 lines
makesdna/
1 line
makesrna/
intern/
5 lines

Diff 43613

View Options

release/scripts/startup/bl_ui/space_sequencer.py

Loading...
View Options

source/blender/editors/space_sequencer/space_sequencer.c

Loading...
View Options

source/blender/makesdna/DNA_space_types.h

Loading...
View Options

source/blender/makesrna/intern/rna_space.c

Loading...