Fix T91808: Batch Generate Previews fails
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 20 2021, 12:27 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Bastien Montagne (mont29)

Maniphest Tasks

T91808: Data Previews are no longer saved

Commits

rB690e1baf722c: Fix T91808: Batch Generate Previews fails

Summary

Caused by the Cycles-X merge.

The old style of tile rendering was removed, leaving the script to error
out trying to set the tile size.

Tile rendering came back in a new form (but only really relevant for
large resolution rendering), so now leave setting auto_tile & tile_size
alone (since previews are rendered at PREVIEW_RENDER_DEFAULT_HEIGHT 128

which should never make a difference here).

Diff Detail

Repository

rB Blender

Branch

T91808 (branched from master)

Build Status

Buildable 18032
Build 18032: arc lint + arc unit

Event Timeline

Philipp Oeser (lichtwerk) created this revision.Oct 20 2021, 12:27 PM

Harbormaster completed remote builds in B18032: Diff 43623.Oct 20 2021, 12:27 PM

Philipp Oeser (lichtwerk) requested review of this revision.Oct 20 2021, 12:27 PM

Brecht Van Lommel (brecht) accepted this revision.Oct 20 2021, 12:34 PM

This revision is now accepted and ready to land.Oct 20 2021, 12:34 PM

Bastien Montagne (mont29) accepted this revision.Oct 20 2021, 12:39 PM

Closed by commit rB690e1baf722c: Fix T91808: Batch Generate Previews fails (authored by Philipp Oeser (lichtwerk)). · Explain WhyOct 20 2021, 12:49 PM

This revision was automatically updated to reflect the committed changes.

Philipp Oeser (lichtwerk) added a commit: rB690e1baf722c: Fix T91808: Batch Generate Previews fails.

Revision Contents
Changeset List

Path

Size

release/

scripts/

modules/

bl_previews_utils/

bl_previews_render.py

2 lines

Diff 43623

View Options

release/scripts/modules/bl_previews_utils/bl_previews_render.py

Fix T91808: Batch Generate Previews failsClosedPublicActions