Page MenuHome
Differential D12939

UI: Header / Tool Settings: Show tool icon when tools are collapsed
ClosedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Oct 20 2021, 4:42 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Pablo Vazquez (pablovazquez)
Commits
rB84bb6d7c02d1: UI: Header / Tool Settings: Show tool icon when tools are collapsed
Summary

Show the scaled down tool icon when the tool region is collapsed. Show a
blank space when the tool region is visible.

  • Minimize the UI flickering when changing the active tool.
  • Show the active tool when the tool region is collapsed.
  • Smaler header footprint (the tool name is not visible).

This is a follow up for T91536.

Test file:

icons.blend95 KBDownload

Diff Detail

Repository
rB Blender
Branch
ui-dynamic-icon-show (branched from master)
Build Status
Buildable 18043
Build 18043: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) requested review of this revision.Oct 20 2021, 4:42 PM
Dalai Felinto (dfelinto) created this revision.
Harbormaster completed remote builds in B18043: Diff 43637.Oct 20 2021, 4:42 PM
Dalai Felinto (dfelinto) edited the summary of this revision. (Show Details)Oct 20 2021, 4:49 PM
Dalai Felinto (dfelinto) added a reviewer: Campbell Barton (campbellbarton).
Dalai Felinto (dfelinto) added a project: User Interface.
Dalai Felinto (dfelinto) added subscribers: Pablo Vazquez (pablovazquez), Francesco Siddi (fsiddi).
Dalai Felinto (dfelinto) updated this revision to Diff 43642.Oct 20 2021, 5:35 PM

Simplify code

Harbormaster completed remote builds in B18047: Diff 43642.Oct 20 2021, 5:35 PM
Dalai Felinto (dfelinto) mentioned this in D12943: UI: Remove extra padding on Annotate tool settings.Oct 20 2021, 5:54 PM
Gilberto Rodrigues (gilberto_rodrigues) awarded a token.Oct 20 2021, 6:43 PM
Dalai Felinto (dfelinto) mentioned this in rB1de837437498: UI: Remove extra padding on Annotate tool settings.Oct 20 2021, 7:02 PM
Alessio Monti di Sopra (a.monti) added a subscriber: Alessio Monti di Sopra (a.monti).Oct 20 2021, 7:04 PM

Hi! I honestly don't get why the icon couldn't be always visible.

There is no space gain in hiding it, since it's needed to avoid the text jumping, and it would give context to the user to understand what those options are for.

Dalai Felinto (dfelinto) added a comment.Oct 21 2021, 11:09 AM

@Alessio Monti di Sopra (a.monti) hi, the reason was that there is no need for the icon when the tools are visible, since the active tool is marked as active.

Alessio Monti di Sopra (a.monti) added a comment.Oct 21 2021, 11:38 AM

Well, ok, but to me it still seems quite a random thing to do.
I mean, I see no gain in hiding the icon, and the blank space looks a bit strange.

Campbell Barton (campbellbarton) accepted this revision.Oct 21 2021, 12:00 PM
This revision is now accepted and ready to land.Oct 21 2021, 12:00 PM
Pablo Vazquez (pablovazquez) accepted this revision.Oct 21 2021, 12:09 PM
Closed by commit rB84bb6d7c02d1: UI: Header / Tool Settings: Show tool icon when tools are collapsed (authored by Dalai Felinto (dfelinto)). · Explain WhyOct 21 2021, 12:12 PM
This revision was automatically updated to reflect the committed changes.
Dalai Felinto (dfelinto) added a commit: rB84bb6d7c02d1: UI: Header / Tool Settings: Show tool icon when tools are collapsed.

Revision Contents
Changeset List

PathSize
release/
scripts/
startup/
bl_ui/
17 lines

Diff 43637

View Options

release/scripts/startup/bl_ui/space_toolsystem_common.py

Loading...