Turn off cyclic if either mode is currently trimming so that the node works
with cyclic curves.
Details
Details
- Reviewers
Hans Goudey (HooglyBoogly)
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- trimc (branched from master)
- Build Status
Buildable 18049 Build 18049: arc lint + arc unit
Event Timeline
Comment Actions
Unfortunately I don't think it's quite this simple, since the trimming should also consider the cyclic portion of the curve between the last and first points.
For example, on a cyclic quadrilateral input, input factors 0.8-0.9 should give a spline that is in between the last and first point.
Comment Actions
While adding a point to the end of the spline is a valid solution, it also has the downside that the spline will need to be re-evaluated if it is already evaluated. While that's totally fine for curves without many points, it's probably bad enough for large ones that I would like to avoid it.
So, I think I'll push a little more for a solution that changes the logic of the trim_bezier_spline, trim_poly_spline, etc. functions. For Poly splines I'd guess that it wouldn't be too bad. Beziers would probably be a bit more complicated, but still seems doable, and NURBS is just the same thing as Poly but a little bit different.