Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing.
ClosedPublic
Actions

Authored by William Leeson (leesonw) on Oct 20 2021, 8:56 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Ray Molenkamp (LazyDodo)

Commits

rC9015f1f58cb3: Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing.
rBf0df0e9e07f9: Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing.

Summary

The conversion from double to float for atof in D12834 was causing a build failure.

Diff Detail

Repository

rB Blender

Branch

updateRemoveOffsetting (branched from master)

Build Status

Buildable 18053
Build 18053: arc lint + arc unit

Event Timeline

William Leeson (leesonw) requested review of this revision.Oct 20 2021, 8:56 PM

William Leeson (leesonw) created this revision.

Harbormaster completed remote builds in B18053: Diff 43656.Oct 20 2021, 8:56 PM

William Leeson (leesonw) edited the summary of this revision. (Show Details)Oct 20 2021, 8:57 PM

William Leeson (leesonw) added reviewers: Brecht Van Lommel (brecht), Ray Molenkamp (LazyDodo).

William Leeson (leesonw) added a project: Cycles.

You can just commit a fix like this directly, especially if the buildbot is failing.

This revision is now accepted and ready to land.Oct 20 2021, 8:59 PM

Ray Molenkamp (LazyDodo) accepted this revision.Oct 20 2021, 9:01 PM

Closed by commit rBf0df0e9e07f9: Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing. (authored by William Leeson (leesonw)). · Explain WhyOct 20 2021, 9:08 PM

This revision was automatically updated to reflect the committed changes.

William Leeson (leesonw) added a commit: rBf0df0e9e07f9: Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing..

Brecht Van Lommel (brecht) added a commit: rC9015f1f58cb3: Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing..Jan 27 2022, 11:30 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

device/

hip/

queue.cpp

2 lines

Diff 43656

View Options

intern/cycles/device/hip/queue.cpp

Fix: Add cast to atof for CYCLES_CONCURRENT_STATES_FACTOR env variable parsing.ClosedPublicActions