Adjusts when the UI surrounding Scrambling Distance settings is greyed out to better reflect restrictions put in place by the adaptive sampling feature.
Details
Details
Diff Detail
Diff Detail
- Repository
- rB Blender
- Branch
- scramble-distance-updated-ui-sobol (branched from master)
- Build Status
Buildable 18254 Build 18254: arc lint + arc unit
Event Timeline
Comment Actions
The code changes in ui.py attempt to change the way the UI for the scrambling distance settings is grayed out.
The code change made in sync.cpp are taken from D12854: Cycles: Scrambling distance for the PMJ sampler. This code change is required to stop the rendered viewport from refreshing in situations it shouldn't.
Comment Actions
Looks good but the files have been renamed and moved so it needs to be updated. These change are similar to D12854 right? So I have updated that and you could take it from there.
Comment Actions
- Rebase on Master with Sobol Scramble Distance Code
You can find a version of this patch to apply on top of D12854: Cycles: Scrambling distance for the PMJ sampler here:
Comment Actions
Sorry, I just noticed this. I think the logic needs to change if I have adaptive on the render settings then it still enables scrambling distance. I think it should be an or (||) for the first 2 active settings.
Comment Actions
The issue with having the or logic is that when adpative sampling is enabled for the final render, but disabled for the viewport, then settings like Scrambling Distance Strength is greyed out when it is still relevant for viewport rendering.
A similar thing applies to the other way around. When adaptive sampling is on for the viewport, but off for the final render, settings like Scrambling Distance Strength are greyed out when it is still relevant to the final render.