Page MenuHome
Differential D12974

VSE: `Frame All` inside metastrips uses meta range
ClosedPublic
Actions

Authored by Andrea Beconcini (beco) on Oct 23 2021, 6:36 PM.

Details

Reviewers
Richard Antalik (ISS)
Maniphest Tasks
T90633: VSE: "Frame all" inside metastrips uses global frame range instead of metastrip frame range
Commits
rB82ae7b990acf: Fix T90633: Frame all doesn't use meta range
Summary

This commit fixes T90633, it changes the behavior of the Frame All
operation when the user is tabbed into a metastrip: instead of using
the global timeline's range, Frame All uses the current metastrip's
range.

Diff Detail

Repository
rB Blender

Event Timeline

Andrea Beconcini (beco) requested review of this revision.Oct 23 2021, 6:36 PM
Andrea Beconcini (beco) created this revision.
Harbormaster completed remote builds in B18153: Diff 43829.Oct 23 2021, 6:36 PM
Andrea Beconcini (beco) added inline comments.Oct 23 2021, 6:48 PM
source/blender/editors/space_sequencer/sequencer_view.c
95–102

Here I called SEQ_timeline_init_boundbox for the "magic numbers" it uses for the y-axis (I wanted to avoid duplicating those 0.0 and 8.0 initial values and keep them in a single place instead).

Andrea Beconcini (beco) added a reviewer: Richard Antalik (ISS).Oct 23 2021, 7:05 PM
Richard Antalik (ISS) accepted this revision.Oct 25 2021, 6:46 AM
Richard Antalik (ISS) added inline comments.
source/blender/editors/space_sequencer/sequencer_view.c
96–98

I would preffer getting active metastack and then just check if you get NULL instead of accessing Editing members directly.

This revision is now accepted and ready to land.Oct 25 2021, 6:46 AM
Closed by commit rB82ae7b990acf: Fix T90633: Frame all doesn't use meta range (authored by Andrea Beconcini (beco), committed by Richard Antalik (ISS)). · Explain WhyOct 25 2021, 6:51 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rB82ae7b990acf: Fix T90633: Frame all doesn't use meta range.
Martijn Versteegh (Baardaap) mentioned this in T94254: Crash when the Home button is pressed in the VSE.Dec 20 2021, 12:46 AM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
9 lines
sequencer/
2 lines
intern/
31 lines

Diff 43871

View Options

source/blender/editors/space_sequencer/sequencer_view.c

Loading...
View Options

source/blender/sequencer/SEQ_time.h

Loading...
View Options

source/blender/sequencer/intern/strip_time.c

Loading...