Page MenuHome
Differential D12983

Geometry Nodes: Use vector socket for offset in Set Position node.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 24 2021, 8:30 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T92348: Geometry Nodes: Set Position node uses implicit position for "Offset" mode, causing unintended displacement
Commits
rBb3ca926aa8e1: Geometry Nodes: use vector socket for offset in Set Position node
Summary

This replaces the boolean Offset input in the Set Position node with a Vector input.

Old:


New:

Diff Detail

Repository
rB Blender
Branch
set-position-offset (branched from master)
Build Status
Buildable 18170
Build 18170: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 24 2021, 8:30 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18170: Diff 43856.Oct 24 2021, 8:30 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 24 2021, 8:30 PM
Jacques Lucke (JacquesLucke) added a task: T92348: Geometry Nodes: Set Position node uses implicit position for "Offset" mode, causing unintended displacement.
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Oct 24 2021, 8:33 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Hans Goudey (HooglyBoogly) accepted this revision.Oct 25 2021, 6:22 AM

Great, this is simpler-- rather than repurpose the meaning of a socket with the offset toggle, we just make it its own thing, simplifying and speeding up both cases. The commit message could say something like that to provide reasoning for the change.

Just testing the versioning and figured I might post before and after screenshots here:

It seems good enough to me. The node has only been around for so long anyway.

source/blender/nodes/geometry/nodes/node_geo_set_position.cc
63

We could check whether the offsets are single and zero before including them in the loop. I don't care if you do that now or we do it later though.

This revision is now accepted and ready to land.Oct 25 2021, 6:22 AM
Closed by commit rBb3ca926aa8e1: Geometry Nodes: use vector socket for offset in Set Position node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyOct 25 2021, 11:39 AM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBb3ca926aa8e1: Geometry Nodes: use vector socket for offset in Set Position node.
Lopo Isaac (lopoIsaac) awarded a token.Oct 25 2021, 12:20 PM
Vyacheslav (hitrpr) awarded a token.Nov 9 2021, 6:24 AM

Revision Contents
Changeset List

PathSize
source/
blender/
blenloader/
intern/
47 lines
nodes/
geometry/
nodes/
11 lines

Diff 43856

View Options

source/blender/blenloader/intern/versioning_300.c

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_set_position.cc

Loading...