Page MenuHome

Fix T92494: Node Editor dot grid not respecting display resolution scale
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Oct 26 2021, 12:36 PM.

Details

Summary

This seems wrong and was especially noticeable since transform snapping
does account for it (which was reported in T92494).
Now divide the DotGridLevelInfo step_factor by the default of 20 for
U.widget_unit and scale it later by the actual interface scale.

note: when zooming, this will still always snap to the smallest dot
level (not sure, with a bit more work it could be possible to only snap
to the lowest visible level after fading?)

Diff Detail

Repository
rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 26 2021, 12:36 PM
Philipp Oeser (lichtwerk) created this revision.

Thanks, this makes sense

source/blender/editors/interface/view2d.c
1366

It's not quite right to call something specific to the node editor here, since this is supposed to be more general. U.widget_unit directly would be simpler.

This revision is now accepted and ready to land.Oct 26 2021, 2:59 PM