UI: Use text highlight theme color for active tab
ClosedPublic
Actions

Authored by Pablo Vazquez (pablovazquez) on Oct 26 2021, 12:52 PM.

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

User Interface

Commits

rBaf26720b2131: UI: Use text highlight theme color for active tab

Summary

Currently, both inactive and active tabs are using the Region Text theme property.
This patch makes it so active tabs use Region Text Highlight.

Since this check is done in other places already but was simply missing in this case, I believe this was just an oversight and not a design decision.

Top is master, bottom is this patch:

This allows this kind of tab highlight, not possible before since all tabs would have white text.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Oct 26 2021, 12:52 PM

Pablo Vazquez (pablovazquez) created this revision.

Harbormaster completed remote builds in B18226: Diff 43956.Oct 26 2021, 12:52 PM

Pablo Vazquez (pablovazquez) edited the summary of this revision. (Show Details)Oct 26 2021, 12:57 PM

Pablo Vazquez (pablovazquez) added a reviewer: User Interface.

Makes sense. Hopefully this won't cause issues for other themes. Have you checked with the builtin ones?

In D13003#342496, @Julian Eisel (Severin) wrote:

Makes sense. Hopefully this won't cause issues for other themes. Have you checked with the builtin ones?

Both light and dark themes work. Some of the community ones might look better with darker text, although I'm not sure who is in charge of decisions for community themes.

This is how they currently look with this patch: