Fix T92427: Adding nodes does no edge-scrolling
ClosedPublic
Actions

Authored by Philipp Oeser (lichtwerk) on Oct 26 2021, 1:45 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Pablo Vazquez (pablovazquez)
Jacques Lucke (JacquesLucke)

Maniphest Tasks

T92427: Nodes teleports when the mouse touches the border of the editor

Commits

rB4d605ef2f413: Fix T92427: Adding new nodes does no edge-panning

Summary

Unlike translating existing nodes [which disables cursor wrapping and
enables edge-scrolling instead since rBSa1cc7042a745], adding new nodes
would still show the old behavior of cursor wrapping.

This has been disabled for the case when the node whould be added outside (due to menus overlapping other editors).

Now enable edge-scrolling for adding new nodes as well and make sure
this only starts once the mouse has returned into the inside rect once.

Diff Detail

Repository: rB Blender

Event Timeline

Philipp Oeser (lichtwerk) requested review of this revision.Oct 26 2021, 1:45 PM

Philipp Oeser (lichtwerk) created this revision.

Harbormaster completed remote builds in B18227: Diff 43961.Oct 26 2021, 1:45 PM

Philipp Oeser (lichtwerk) added projects: User Interface, Nodes.Oct 26 2021, 1:45 PM

Jacques Lucke (JacquesLucke) accepted this revision.Oct 26 2021, 2:42 PM

This revision is now accepted and ready to land.Oct 26 2021, 2:42 PM

I actually think this might have been an intentional change in D11736, but I missed that in review, and I think it's weirdly inconsistent.
I also usually want edge panning when adding a node so I can position it correctly. So +1 for adding this pack.

Okay, now I remember why this was changed, it was this situation here:

Often when you added a node the add menu would end up above the node editor, so it would start panning immediately.
I think the one fix is clear though, it should only start panning once the node has been moved back into the view.
The current behavior isn't ideal because it's turned off even when not in that "out of bounds" situation.