Fix T92423: Blender freeze rendering animation with Mantaflow
ClosedPublic
Actions

Authored by Sergey Sharybin (sergey) on Oct 27 2021, 2:44 PM.

Details

Reviewers

Brecht Van Lommel (brecht)

Maniphest Tasks

T92423: Blender freeze rendering animation with Mantaflow

Commits

rB8507336e7690: Fix T92423: Blender freeze rendering animation with Mantaflow

Summary

Mantaflow could steal tasks from dependency graph, which under
certain conditions causes a recursive lock involving GIL.

Isolate threading done in mantaflow when it is interfaced form
the dependency graph.

Isolation done from the modifier, since the deeper calls are
branching out quite quickly.

Diff Detail

Repository

rB Blender

Branch

fix_T92423 (branched from master)

Build Status

Buildable 18262
Build 18262: arc lint + arc unit

Event Timeline

Sergey Sharybin (sergey) requested review of this revision.Oct 27 2021, 2:44 PM

Sergey Sharybin (sergey) created this revision.

Harbormaster completed remote builds in B18262: Diff 44021.Oct 27 2021, 2:44 PM

While testing the fix I've once run into if (used != 0) errMsg("can't clean grid cache, some grids are still in use"); trigger from FluidSolver::GridStorage<T>::free(). Can not reproduce it so far, but doesn't seem to be related on the isolation.

Peter Baintner (predoe) awarded a token.Oct 27 2021, 2:48 PM

Brecht Van Lommel (brecht) accepted this revision.Oct 27 2021, 2:49 PM

This revision is now accepted and ready to land.Oct 27 2021, 2:49 PM

Raimund Klink (Raimund58) awarded a token.Oct 27 2021, 2:50 PM

Closed by commit rB8507336e7690: Fix T92423: Blender freeze rendering animation with Mantaflow (authored by Sergey Sharybin (sergey)). · Explain WhyOct 27 2021, 2:53 PM

This revision was automatically updated to reflect the committed changes.

Sergey Sharybin (sergey) added a commit: rB8507336e7690: Fix T92423: Blender freeze rendering animation with Mantaflow.