Page MenuHome

Fix install paths for blender thumbnailer when not building a portable install
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Oct 27 2021, 7:00 PM.

Details

Summary

When doing a non portable build of blender, the executable blender-thumbnailer would be installed in two locations:
/usr/bin/ and /usr/

Having two binaries of the same program installed seems like an oversight, especially since one of them is installed in a incorrect place.

@Campbell Barton (campbellbarton) is there any reason for having an install directive in the cmake files here?
I have no idea about windows, but at least on linux and mac I don't see why we would have that in this file when we already have logic for this in source/creator/CMakeLists.txt.
Perhaps I'm missing something or could we just remove these install instructions all together from the thumbnailer cmake files?

Diff Detail

Event Timeline

Sebastian Parborg (zeddb) requested review of this revision.Oct 27 2021, 7:00 PM
Sebastian Parborg (zeddb) created this revision.

Adding Ray as well for the windows part that I haven't changed yet.
Is the install for windows needed here?

This revision is now accepted and ready to land.Oct 28 2021, 1:40 PM

Yeah seems superfluous, since it has slightly different paths for each platform in source/creator/CMakeLists.txt i agree that one should live, this one should go.

Updated with windows related changes.

Tested with it on and off, checks out!