Fix T91986: Incorrect syncing of geometry instances.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Oct 28 2021, 11:06 AM.

Details

Reviewers

William Leeson (leesonw)
Brecht Van Lommel (brecht)

Maniphest Tasks

T91986: Instancing letters with Cycles render

Commits

rBc7fcc50842d8: Fix T91986: incorrect syncing of geometry instances

Summary

The issue was that some geometries were not synced again even when they changed. This patch adds a map that keeps track of the geometries that need to be updated when an object has changed.

Diff Detail

Repository

rB Blender

Branch

cycles-geometry-instance-sync (branched from master)

Build Status

Buildable 18363
Build 18363: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 28 2021, 11:06 AM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B18287: Diff 44064.Oct 28 2021, 11:06 AM

Jacques Lucke (JacquesLucke) added a task: T91986: Instancing letters with Cycles render.Oct 28 2021, 11:07 AM

Merge branch 'blender-v3.0-release' into cycles-geometry-instance-sync
cleanup

Harbormaster completed remote builds in B18363: Diff 44198.Nov 1 2021, 12:40 PM

Jacques Lucke (JacquesLucke) retitled this revision from Fix T91986: Incorrect syncing of geometry instances (WIP). to Fix T91986: Incorrect syncing of geometry instances..Nov 1 2021, 12:42 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Jacques Lucke (JacquesLucke) added reviewers: William Leeson (leesonw), Brecht Van Lommel (brecht).

Jacques Lucke (JacquesLucke) mentioned this in T92606: Geometry nodes output gets synced to cycles wrong..Nov 1 2021, 12:46 PM

Martijn Versteegh (Baardaap) added a subscriber: Martijn Versteegh (Baardaap).Nov 3 2021, 9:44 PM

This comment was removed by Martijn Versteegh (Baardaap).

I was trying to think of a cleaner solution, but can't think of anything without a bigger redesign of this API, so looks good to me.

This revision is now accepted and ready to land.Nov 4 2021, 4:53 PM

Closed by commit rBc7fcc50842d8: Fix T91986: incorrect syncing of geometry instances (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 4 2021, 6:32 PM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rBc7fcc50842d8: Fix T91986: incorrect syncing of geometry instances.

Raimund Klink (Raimund58) awarded a token.Nov 5 2021, 9:42 AM