Cycles: Remove device checks for half float support
ClosedPublic
Actions

Authored by Thomas Dinges (dingto) on Oct 28 2021, 12:07 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Commits

rC59627f0391f3: Cleanup: Remove Cycles device checks for half float
rB5327413b3776: Cleanup: Remove Cycles device checks for half float.

Summary

All supported devices support half float now, so we can remove the flag to check for it.

Diff Detail

Event Timeline

Thomas Dinges (dingto) requested review of this revision.Oct 28 2021, 12:07 PM

Thomas Dinges (dingto) created this revision.

Brecht Van Lommel (brecht) accepted this revision.Oct 28 2021, 12:24 PM

This revision is now accepted and ready to land.Oct 28 2021, 12:24 PM

Not only all devices does now support half-floats, I don't think we should aim support of possible new devices which don't have half-float support since it will get in a way with some planned memory optimizations.

There seems to be a mistake in the assert statement though.

intern/cycles/scene/image.cpp
358–359	Doesn't seem correct to me: the `features.has_half_float` is `true`, so the short-circuited assert before the change would be `assert(true)`. Seems the assert can simply be removed. Otherwise it "forbids" using half-float images.