Page MenuHome
Differential D13024

Fix T92532: Missing null checks in IDPropertyManager.update_from
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Oct 28 2021, 9:14 PM.

Details

Reviewers
Campbell Barton (campbellbarton)
Maniphest Tasks
T92532: Python: calling id_properties_ui(key).update() without arguments, crashes blender
Commits
rBefcf36f2e977: Fix T92532: Missing null checks in IDPropertyManager.update_from
Summary

Calling it with a None argument, or no arguments, or with a property
that is missing UI data for some reason would fail. There is no
particular reason why ensuring those things don't happen is helpful,
so just add null chekcs for safety.

Diff Detail

Repository
rB Blender
Branch
fix-update-from-crash (branched from master)
Build Status
Buildable 18292
Build 18292: arc lint + arc unit

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Oct 28 2021, 9:14 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B18292: Diff 44074.Oct 28 2021, 9:14 PM
Hans Goudey (HooglyBoogly) added a task: T92532: Python: calling id_properties_ui(key).update() without arguments, crashes blender.Oct 28 2021, 9:15 PM
Hans Goudey (HooglyBoogly) added a reviewer: Campbell Barton (campbellbarton).
Hans Goudey (HooglyBoogly) added a project: Python API.
Campbell Barton (campbellbarton) accepted this revision.Nov 2 2021, 12:23 PM
Campbell Barton (campbellbarton) added inline comments.
source/blender/python/generic/idprop_py_ui_api.c
625

ui_manager_src NULL check is redundant, otherwise LGTM.

This revision is now accepted and ready to land.Nov 2 2021, 12:23 PM
Closed by commit rBefcf36f2e977: Fix T92532: Missing null checks in IDPropertyManager.update_from (authored by Hans Goudey (HooglyBoogly)). · Explain WhyNov 2 2021, 1:59 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBefcf36f2e977: Fix T92532: Missing null checks in IDPropertyManager.update_from.

Revision Contents
Changeset List

PathSize
source/
blender/
python/
generic/
4 lines

Diff 44074

View Options

source/blender/python/generic/idprop_py_ui_api.c

Loading...