Differential D13028
Fix T92469: Transform tools inaccessible in weight-paint + pose mode Authored by Campbell Barton (campbellbarton) on Oct 29 2021, 6:41 AM. Tags Subscribers None
Details Expose transform tools when in weight paint mode with pose-mode enabled, These are only shown when weight-paint + pose mode are active at once. This allows single key-strokes to activate tools, needed when tool-access is set as the default action for G/R/S key bindings. Screenshot of the toolbar with transform tools in weight+pose mode: 
Diff Detail
Event TimelineComment Actions I don't think this works as intended.
Our build bots can build branches & patches as well. I think it's a better idea to use that & test things properly before they land in master. As for reviewing the code, the _tools dict that things are appended to in this patch is under-documented. There is no indication as to what the keys are, and equally no docs about what the values in the dictionary are. Anonymous lambda functions don't add to the local readability/understandability either. All I can see is that the new code is somewhat similar to the old code, but doing a review so superficially is of little use to anybody. Comment Actions This is working as intended, connected bones fall back to rotate when they are connected or location is locked, and fallback to scale when rotation is locked. This is how pose mode gizmos already work (without weight-paint being enabled), so I think it's out of scope for this patch to make changes here.
The _tools are for internal use, to store data to return from tools_from_context and tools_all, committed some code comments noting this as well as notes on the dictionary values. Comment Actions The new comments help a bit, but the overall design of the code is so far away from what I would find good design, that I really can't comment on whether this change is doing the right thing or not. Because of this, I'll resign as reviewer. |