BGE: Adding a Max Jumps value to the character physic window
ClosedPublic
Actions

Authored by Thomas Szepe (hg1) on May 15 2015, 4:48 PM.

Details

Reviewers

Campbell Barton (campbellbarton)
Sybren A. Stüvel (sybren)
Porteries Tristan (panzergame)
Jorge Bernal (lordloki)
Mitchell Stokes (moguri)
Angus Hollands (agoose77)

Commits

rBS3dd83b533a03: BGE: Adding a Max Jumps value to the character physic window
rB3dd83b533a03: BGE: Adding a Max Jumps value to the character physic window

Summary

Actually we only have a Python API that allows to change the max jumps value.
The patch also allows non programmers to change the maximum numbers of jumps.

Diff Detail

Event Timeline

Test file:

characterTest.blend88 KBDownload

Looks good to me. I don't know if we really need to use an integer for the max jump count (especially since you limit the property to 100, which can fit in a char). Is the UI limit a hard or soft limit? In other words could I type in something over 100? A lower soft limit (say 5 or 10) might make the slider respond smother for typical use cases.

This revision is now accepted and ready to land.May 15 2015, 5:26 PM

In D1302#25506, @Mitchell Stokes (moguri) wrote:

Looks good to me. I don't know if we really need to use an integer for the max jump count (especially since you limit the property to 100, which can fit in a char). Is the UI limit a hard or soft limit? In other words could I type in something over 100? A lower soft limit (say 5 or 10) might make the slider respond smother for typical use cases.

It is a hard limit. Maybe, something like:

	RNA_def_property_range(prop, 1, INT_MAX);
	RNA_def_property_ui_range(prop, 1, 100, 1, 1);

it would be better.

Other than this, it looks ok to me.

Jorge Bernal (lordloki) edited edge metadata.May 18 2015, 7:12 AM

Jorge Bernal (lordloki) added a project: Game Engine.

Changes:

Changed int to unsigned char.
Add hard or soft limit to max jump count.

Angus Hollands (agoose77) edited edge metadata.Jun 18 2015, 1:31 AM

This comment was removed by Angus Hollands (agoose77).

In D1302#27280, @Angus Hollands (agoose77) wrote:

As with the other revision, I'd like for the Python API to fail if an invalid value for max jumps is provided, but otherwise OK.

I don't understand your sentence. Which Python API? This is a patch for the UI there is no API. Also it is impossible to sett an invalid value via UI.