Page MenuHome

Fix T92256: Rotate Instances node does not take scaling into account correctly.
ClosedPublic

Authored by Jacques Lucke (JacquesLucke) on Oct 29 2021, 12:21 PM.

Details

Summary

The goal here is to make sure that the node always only does a rotation.

In my simple test the behavior seems to match the old code as long as instances are scaled uniformly. It would be useful if you could verify that in your own test.

Diff Detail

Repository
rB Blender
Branch
rotate-instances-cleanup (branched from master)
Build Status
Buildable 18313
Build 18313: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Oct 29 2021, 12:21 PM
Jacques Lucke (JacquesLucke) created this revision.
Jacques Lucke (JacquesLucke) retitled this revision from Fix T92256: Rotate Instances scaled the instance. to Fix T92256: Rotate Instances node does not take scaling into account correctly..Oct 29 2021, 12:26 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)

Doing some rudimentary testing, this seems to work well. I really appreciate the comments too, it's much easier to understand now.

This revision is now accepted and ready to land.Oct 29 2021, 7:25 PM