Page MenuHome
Differential D13036

SVG import: transform skewX and skewY swapped
ClosedPublic
Actions

Authored by Diptangshu Dey (Tha_Hobbist) on Oct 29 2021, 7:58 PM.

Details

Reviewers
Yevgeny Makarov (jenkm)
Sergey Sharybin (sergey)
Commits
rBAd169df69b3f5: Fix T81374: SVG import: transform skewX and skewY swapped
Summary

This Commit fixes the issue: T81374

When importing an SVG file that uses skewX and skewY, they are confused.
This patch swaps the skewX and skewY functions and hence the problem is resolved.

Diff Detail

Event Timeline

Diptangshu Dey (Tha_Hobbist) requested review of this revision.Oct 29 2021, 7:58 PM
Diptangshu Dey (Tha_Hobbist) created this revision.
Harbormaster completed remote builds in B18321: Diff 44122.Oct 29 2021, 7:58 PM
Diptangshu Dey (Tha_Hobbist) retitled this revision from Revert "Fix T92334: Amaranth errors after cycles-x changes" to Fix to T81374.Oct 29 2021, 8:03 PM
Yevgeny Makarov (jenkm) requested changes to this revision.Oct 29 2021, 9:21 PM
Yevgeny Makarov (jenkm) added a subscriber: Yevgeny Makarov (jenkm).

Need to remove accidental changes here.

This revision now requires changes to proceed.Oct 29 2021, 9:21 PM
Yevgeny Makarov (jenkm) edited the summary of this revision. (Show Details)Oct 29 2021, 9:21 PM
Diptangshu Dey (Tha_Hobbist) updated this revision to Diff 44128.Oct 29 2021, 10:12 PM

Updated Commit to Fix T81374

Harbormaster completed remote builds in B18325: Diff 44128.Oct 29 2021, 10:12 PM
Diptangshu Dey (Tha_Hobbist) updated this revision to Diff 44129.Oct 29 2021, 10:25 PM
  • Fixed a comment typo
Harbormaster completed remote builds in B18326: Diff 44129.Oct 29 2021, 10:25 PM
Diptangshu Dey (Tha_Hobbist) retitled this revision from Fix to T81374 to SVG import: transform skewX and skewY swapped.Oct 29 2021, 10:37 PM
Diptangshu Dey (Tha_Hobbist) edited the summary of this revision. (Show Details)
Yevgeny Makarov (jenkm) added a comment.Oct 30 2021, 6:37 PM

Tested with these two files, looks good to me.

SVG-skewY.svg295 BDownload

SVG-skewX.svg307 BDownload

Ankit Meel (ankitm) added projects: Add-ons (BF-Blender), Import/Export.Oct 30 2021, 6:38 PM
Yevgeny Makarov (jenkm) accepted this revision.Oct 30 2021, 6:44 PM
Yevgeny Makarov (jenkm) added a reviewer: Sergey Sharybin (sergey).
Yevgeny Makarov (jenkm) added a subscriber: Sergey Sharybin (sergey).

I will add @Sergey Sharybin (sergey), as he is the author.

This revision is now accepted and ready to land.Oct 30 2021, 6:44 PM
Ankit Meel (ankitm) added 1 blocking reviewer(s): Sergey Sharybin (sergey).Oct 30 2021, 6:45 PM
This revision now requires review to proceed.Oct 30 2021, 6:45 PM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 5 2021, 11:39 AM
Closed by commit rBAd169df69b3f5: Fix T81374: SVG import: transform skewX and skewY swapped (authored by Diptangshu Dey (Tha_Hobbist), committed by Sergey Sharybin (sergey)). · Explain Why
This revision was automatically updated to reflect the committed changes.
Sergey Sharybin (sergey) added a commit: rBAd169df69b3f5: Fix T81374: SVG import: transform skewX and skewY swapped.

Revision Contents
Changeset List

PathSize
io_curve_svg/
4 lines

Diff 44128

View Options

io_curve_svg/import_svg.py

Loading...