Fix T92575: Black pixels appear with PMJ sampling.
ClosedPublic
Actions

Authored by William Leeson (leesonw) on Oct 29 2021, 11:56 PM.

Details

Reviewers

Brecht Van Lommel (brecht)
Sergey Sharybin (sergey)

Maniphest Tasks

T92575: Cycles: With PMJ black pixels appear in the "Monster" scene while rendering ground truth

Commits

rCa48670ae1448: Fix T92575: Cycles black pixels when rendering with > 65k samples
rB0b060905d98c: Fix T92575: Cycles black pixels when rendering with > 65k samples

Summary

This was caused because the sample count was a 16 bit value and
once the sample count went above 65535 the samples repeated.

Diff Detail

Repository: rB Blender

Event Timeline

William Leeson (leesonw) requested review of this revision.Oct 29 2021, 11:56 PM

William Leeson (leesonw) created this revision.

Harbormaster completed remote builds in B18327: Diff 44130.Oct 29 2021, 11:56 PM

William Leeson (leesonw) added a task: T92575: Cycles: With PMJ black pixels appear in the "Monster" scene while rendering ground truth.Oct 29 2021, 11:56 PM

William Leeson (leesonw) added reviewers: Brecht Van Lommel (brecht), Sergey Sharybin (sergey).

William Leeson (leesonw) added a project: Render & Cycles.

This seems to fix the black pixels for me but you may not want to increase the size of this value for rendering with huge numbers of pixel.

Now it looks like this :-)

The shadow state needs to be changed too, but I'll do that in the commit.

This revision is now accepted and ready to land.Oct 31 2021, 10:29 PM

Closed by commit rB0b060905d98c: Fix T92575: Cycles black pixels when rendering with > 65k samples (authored by William Leeson (leesonw), committed by Brecht Van Lommel (brecht)). · Explain WhyNov 1 2021, 8:37 AM

This revision was automatically updated to reflect the committed changes.

Brecht Van Lommel (brecht) added a commit: rB0b060905d98c: Fix T92575: Cycles black pixels when rendering with > 65k samples.

Brecht Van Lommel (brecht) added a commit: rCa48670ae1448: Fix T92575: Cycles black pixels when rendering with > 65k samples.Jan 27 2022, 11:31 PM

Revision Contents
Changeset List

Path

Size

intern/

cycles/

kernel/

integrator/

shadow_state_template.h

2 lines

state_template.h

2 lines

Diff 44188

View Options

intern/cycles/kernel/integrator/shadow_state_template.h