Differential D13041

Geometry Nodes: 4 Selection Input Nodes
AbandonedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Oct 30 2021, 3:19 AM.

Tags

Subscribers

Paul Larson (GeorgiaPacific)

Tokens

"Love" token, awarded by damian."Love" token, awarded by EAW."Love" token, awarded by asmitty."Love" token, awarded by kursadk."Love" token, awarded by Yuro."Love" token, awarded by Leul."Like" token, awarded by manitwo.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Summary

This patch contains 4 new Selection Input nodes. They are in their own "selection" menu.

Plane

Implicit position input, an Origin (plane center), and plane normal input

Cube

Cube Mode, Implicit Position and Size
Rectangle Mode, Implicit Position and Size (by a vector)

Sphere

Implicit Position, Radius

Cylinder

Implicit Position, Height, Radius

Diff Detail

Repository

Branch

selection_nodes (branched from master)

Build Status

Buildable 18329
Build 18329: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Oct 30 2021, 3:19 AM

Johnny Matthews (guitargeek) created this revision.

Harbormaster completed remote builds in B18328: Diff 44134.Oct 30 2021, 3:19 AM

Johnny Matthews (guitargeek) added a reviewer: Hans Goudey (HooglyBoogly).Oct 30 2021, 3:20 AM

Johnny Matthews (guitargeek) added a project: Geometry Nodes.

Formatting

Harbormaster completed remote builds in B18329: Diff 44135.Oct 30 2021, 3:21 AM

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Oct 30 2021, 3:23 AM

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Oct 30 2021, 3:25 AM

Paul Larson (GeorgiaPacific) added a subscriber: Paul Larson (GeorgiaPacific).Oct 30 2021, 5:31 AM

Manuel Grad (manitwo) awarded a token.Oct 30 2021, 12:14 PM

Leul Mulugeta (Leul) awarded a token.Oct 30 2021, 1:25 PM

Yuro (Yuro) awarded a token.Oct 30 2021, 2:04 PM

Move rectangle size to float3
Merge branch 'master' into selection_nodes

Harbormaster completed remote builds in B18337: Diff 44145.Oct 30 2021, 5:26 PM

Add Cylinder Selection

Harbormaster completed remote builds in B18338: Diff 44146.Oct 30 2021, 8:11 PM

Johnny Matthews (guitargeek) retitled this revision from Geometry Nodes: 4 Selection Input Nodes to Geometry Nodes: 5 Selection Input Nodes.Oct 30 2021, 8:20 PM

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)

Add Implicit Normal Input

Harbormaster completed remote builds in B18340: Diff 44151.Oct 30 2021, 11:45 PM

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Oct 30 2021, 11:46 PM

kursad k (kursadk) awarded a token.Oct 31 2021, 1:54 AM

Alex Smith (asmitty) awarded a token.Nov 1 2021, 4:09 AM

Merge branch 'master' into selection_nodes
Remove Normal Compare Selection Node

Harbormaster completed remote builds in B18371: Diff 44210.Nov 1 2021, 9:44 PM

Johnny Matthews (guitargeek) retitled this revision from Geometry Nodes: 5 Selection Input Nodes to Geometry Nodes: 4 Selection Input Nodes.Nov 1 2021, 9:45 PM

Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)

Evan Wilson (EAW) awarded a token.Nov 7 2021, 8:04 AM

Damian (damian) awarded a token.Nov 8 2021, 5:01 PM

Johnny Matthews (guitargeek) abandoned this revision.Dec 13 2021, 4:49 PM

Revision Contents
Changeset List

Path

Size

release/

scripts/

startup/

nodeitems_builtins.py

6 lines

source/

blender/

blenkernel/

5 lines

intern/

4 lines

makesdna/

DNA_node_types.h

10 lines

makesrna/

intern/

23 lines

nodes/

4 lines

4 lines

NOD_static_types.h

4 lines

geometry/

nodes/

node_geo_input_selection_cube.cc

197 lines

node_geo_input_selection_normal.cc

131 lines

node_geo_input_selection_plane.cc

122 lines

node_geo_input_selection_sphere.cc

120 lines

Diff 44135

release/scripts/startup/nodeitems_builtins.py

Loading...

source/blender/blenkernel/BKE_node.h

Loading...

source/blender/blenkernel/intern/node.cc

Loading...

source/blender/makesdna/DNA_node_types.h

Loading...

source/blender/makesrna/intern/rna_nodetree.c

Loading...

source/blender/nodes/CMakeLists.txt

Loading...

source/blender/nodes/NOD_geometry.h

Loading...

source/blender/nodes/NOD_static_types.h

Loading...

source/blender/nodes/geometry/nodes/node_geo_input_selection_cube.cc

Loading...

source/blender/nodes/geometry/nodes/node_geo_input_selection_normal.cc

Loading...

source/blender/nodes/geometry/nodes/node_geo_input_selection_plane.cc

Loading...

source/blender/nodes/geometry/nodes/node_geo_input_selection_sphere.cc

Loading...