Page MenuHome
Differential D13043

Fix T92445: thumbnail height w/out overlay text
ClosedPublic
Actions

Authored by Andrea Beconcini (beco) on Oct 30 2021, 12:18 PM.

Details

Reviewers
Richard Antalik (ISS)
Maniphest Tasks
T92445: VSE: Thumbnails are not full height without overlay texts
Commits
rBdaaa43232d34: Fix T92445: Thumbnail height without overlay text
Summary

This pattch changes the thumbnails' height used for image and movie
strips by choosing the proper size according to the VSE's text overlay
settings: i.e. thumbnails use the whole strip's height when no overlay
text is displayed; otherwise, some space is left for the overlay.

This also changes the thumb_y_end value in draw_seq_strip_thumbnail
by removing a useless subtraction of pixel_y from it.

This patch fixes T92445

Diff Detail

Repository
rB Blender
Branch
full_height_thumbnails (branched from master)
Build Status
Buildable 18408
Build 18408: arc lint + arc unit

Event Timeline

Andrea Beconcini (beco) requested review of this revision.Oct 30 2021, 12:18 PM
Andrea Beconcini (beco) created this revision.
Harbormaster completed remote builds in B18333: Diff 44139.Oct 30 2021, 12:18 PM
Andrea Beconcini (beco) added inline comments.Oct 30 2021, 1:00 PM
source/blender/editors/space_sequencer/sequencer_draw.c
1393

These 0.05f are arbitrary constants i put there because I wanted to leave a partial view of the color of the underlying strip.

source/blender/editors/space_sequencer/sequencer_thumbnails.c
131–132

I am not really happy with this change, I would prefer to retrieve the y2 - y1 range without passing two new parameters to seq_get_thumb_image_dimensions() but this method is also used by the job that computes the thumbnail asynchronously.

I don't think I can retrieve the height I need from that job, because there could be no active sequence during the thumbnail creation (thus I have no access to the actual sequence and the channel it belongs to), that's why I added`y1` and y2 to ThumbnailDrawJob.

473

I am not sure this change is right. I could not understand why we had that - pixely in the first place. AFAIK, pixely is the height of a pixel in screen-space units, and it is used to convert distances from pixels to openGL units. Am I missing something?

I kept this change in a separate commit, so that it can easily be removed in case if wrong.

Andrea Beconcini (beco) added a reviewer: Richard Antalik (ISS).Oct 30 2021, 1:03 PM
Pratik Borhade (PratikPB2123) retitled this revision from fix thumbnail height w/out overlay text to Fix T92445: thumbnail height w/out overlay text.Oct 30 2021, 1:10 PM
Pratik Borhade (PratikPB2123) added a project: Video Sequencer.
Pratik Borhade (PratikPB2123) awarded a token.
Richard Antalik (ISS) requested changes to this revision.Nov 1 2021, 11:04 PM
Richard Antalik (ISS) added a subscriber: Aditya Y Jeppu (quantimoney).

To summarize my position, main objection is reduction of thumbnail size with this patch. I think it is unnecessary. Otherwise I could accept, though if you can eliminate passing additional arguments it would be great.

source/blender/editors/space_sequencer/sequencer_draw.c
1393

I don't really like this change. It makes thumbnails smaller even when text is visible - requires even taller strips to see the thumbnails.

Perhaps there could be small offset when there is no text, and this offset does not need to be on both sides. But I don't think there is need for this offset really.

source/blender/editors/space_sequencer/sequencer_thumbnails.c
131–132

Getting values from running job is quite bad idea - it can have outdated information.

Previously this used SEQ_STRIP_OFSTOP and SEQ_STRIP_OFSBOTTOM defines, which is fine. But (20 * U.dpi_fac * pixely) looks like it is just approximation of text height which is not very great. I didn't notice this during review, I would object to this line then.

Passing these y2 and y1 values is not as terrible really. Alternative would be to define text size similar to SEQ_STRIP_OFSBOTTOM and use this instead.

Even if you added #define SEQ_STRIP_TEXT_HEIGHT (20 * U.dpi_fac * pixely) it would be better than inlining the code directly. Then you need just way to know if text is drawn, this could be abstracted away too, and check can be reused where needed from context instead of passing boundaries. I don't have really strong opinion here, in practice you still need to mix these workflows, but I am not fan of passing 30 variables either.

Issue with adding utility functions to get these parameters is, that it could really use some general drawing code cleanup, because utility functions that look reasonable now may be completely unnecessary if it was structured better.

473

It looks like 1px offset being applied to height on top of thumbnail. Not quite sure why, but doesn't look necessary on first glance. Perhaps @Aditya Y Jeppu (quantimoney) does remember why/if this is necessary.

I don't see visible difference here

This revision now requires changes to proceed.Nov 1 2021, 11:04 PM
Aditya Y Jeppu (quantimoney) added a comment.Nov 2 2021, 11:05 AM
In D13043#344619, @Richard Antalik (ISS) wrote:

It looks like 1px offset being applied to height on top of thumbnail. Not quite sure why, but doesn't look necessary on first glance.

i had put this initially, because the thumbnails used to just touch the text, and intersect the bottom edge of the letters, looked bad. so at the time brute force i think i just added a single pixel width of space and it worked. Doesn't seem to be an issue now

Andrea Beconcini (beco) updated this revision to Diff 44271.Nov 2 2021, 10:21 PM

Fix T92445: thumbnails height w/out overlay text




This commit changes the thumbnails' height used for image and movie

strips by choosing the proper size according to the VSE's text overlay

settings: i.e. thumbnails use almost the whole strip's height when no

overlay text is displayed; otherwise, some space is left for the

overlay.



This also changes the thumb_y_end value in draw_seq_strip_thumbnail

by removing a useless subtraction of pixel_y from it.



These commits fix T92445



Maniphest Tasks: T92445



Differential Revision: https://developer.blender.org/D13043
Harbormaster completed remote builds in B18408: Diff 44271.Nov 2 2021, 10:21 PM
Andrea Beconcini (beco) updated this revision to Diff 44273.Nov 2 2021, 10:24 PM
Fix T92445: thumbnail height w/out overlay text






This commit changes the thumbnails' height used for image and movie

strips by choosing the proper size according to the VSE's text overlay

settings: i.e. thumbnails use almost the whole strip's height when no

overlay text is displayed; otherwise, some space is left for the

overlay.



This also changes the thumb_y_end value in draw_seq_strip_thumbnail

by removing a useless subtraction of pixel_y from it.



These commits fix T92445



Maniphest Tasks: T92445



Differential Revision: https://developer.blender.org/D13043
Harbormaster completed remote builds in B18409: Diff 44273.Nov 2 2021, 10:24 PM
Richard Antalik (ISS) added a comment.Nov 3 2021, 4:08 AM
@Andrea Beconcini (beco) seems like you have merged master into patch branch? I usually do rebase and don't trust arc with any other workflow much... Let me know if you need help. You can always upload diff manually though.
Andrea Beconcini (beco) added a comment.Nov 3 2021, 9:08 AM


In D13043#345164, @Richard Antalik (ISS) wrote:


@Andrea Beconcini (beco) seems like you have merged master into patch branch? I usually do rebase and don't trust arc with any other workflow much... Let me know if you need help. You can always upload diff manually though.





I'm sorry, I had some hard time rebasing the latest changes. I checked out the release branch, run make update (I think it should take care of updating submodules properly), and rebase my local branch on the release one. I am going to fix this within tomorrow and leave a comment when done!
Andrea Beconcini (beco) updated this revision to Diff 44389.Nov 4 2021, 9:57 PM
Harbormaster completed remote builds in B18488: Diff 44389.Nov 4 2021, 9:57 PM
Andrea Beconcini (beco) added a comment.Nov 4 2021, 10:05 PM
rebased and updated.



Thumbnails take the whole strip height when no overlay text is displayed.

The latest revision adds only one extra parameter to ThumbnailDrawJob, thumb_height.
Richard Antalik (ISS) added a comment.Nov 5 2021, 4:39 AM
Thanks for update, will check this patch next week, I want to focus on going through backlog of bugs reported in 3.0 this week.
Richard Antalik (ISS) requested changes to this revision.Nov 5 2021, 5:36 AM
Sorry I forgot this is bugfix, so I will check this out...



I got one nitpick, otherwise I think this is good change. I think even better than my suggestions so far :)
source/blender/editors/space_sequencer/sequencer_thumbnails.c


113
It's very weird to have this return variable then, it should be removed.



Could be simplified to 1 return value IMO, but that's not point of this patch.


471
I would declare const float thumb_height = y2 - y1; here, and remove argument from seq_get_thumb_image_dimensions as I mentioned in inline above.



Then pass it to sequencer_thumbnail_start_job_if_necessary too. Passing y2 - y1 is redundant math and not quite as readable.
This revision now requires changes to proceed.Nov 5 2021, 5:36 AM
Andrea Beconcini (beco) updated this revision to Diff 44888.Nov 17 2021, 9:44 PM
Andrea Beconcini (beco) edited the summary of this revision. (Show Details)
I removed the extra parameter, r_thumb_height, from seq_get_thumb_image_dimensions. Now, there is only thumb_height, which is passed by value.



Moreover, now, the value y2 - y1 is stored in a local variable (const float thumb_height) of draw_seq_strip_thumbnail for re-use.
Harbormaster completed remote builds in B18742: Diff 44888.Nov 17 2021, 9:44 PM
Richard Antalik (ISS) accepted this revision.Nov 18 2021, 2:06 AM
Seems to be good now, Thanks for patch!
This revision is now accepted and ready to land.Nov 18 2021, 2:06 AM
Closed by commit rBdaaa43232d34: Fix T92445: Thumbnail height without overlay text (authored by Andrea Beconcini (beco), committed by Richard Antalik (ISS)).  ·  Explain WhyNov 18 2021, 2:23 AM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBdaaa43232d34: Fix T92445: Thumbnail height without overlay text.
Large Diff
This large diff affects 360 files. Files without inline comments have been collapsed. Expand All Files
Revision Contents
Changeset List
PathSize
intern/
cycles/
blender/
addon/
1 line
8 lines
25 lines
10 lines
2 lines
25 lines
5 lines
4 lines
device/
cpu/
3 lines
cuda/
10 lines
hip/
12 lines
optix/
1 line
integrator/
18 lines
4 lines
kernel/
integrator/
2 lines
2 lines
osl/
shaders/
2 lines
8 lines
svm/
8 lines
2 lines
scene/
8 lines
13 lines
12 lines
2 lines
session/
2 lines
test/
2 lines
util/
2 lines
22 lines
locale/
7 lines
12 lines
release/
scripts/
modules/
bl_i18n_utils/
4 lines
8 lines
presets/
keyconfig/
keymap_data/
112 lines
4 lines
startup/
bl_operators/
2 lines
13 lines
bl_ui/
2 lines
2 lines
1 line
source/
blender/
blenkernel/
6 lines
2 lines
6 lines
4 lines
2 lines
intern/
20 lines
67 lines
4 lines
2 lines
7 lines
4 lines
63 lines
18 lines
2 lines
267 lines
7 lines
2 lines
4 lines
1 line
1 line
6 lines
1 line
blenlib/
4 lines
2 lines
intern/
106 lines
9 lines
2 lines
blenloader/
intern/
2 lines
1 line
1 line
28 lines
2 lines
8 lines
60 lines
2 lines
compositor/
operations/
2 lines
depsgraph/
intern/
2 lines
eval/
2 lines
draw/
engines/
basic/
62 lines
shaders/
7 lines
gpencil/
1 line
image/
2 lines
intern/
5 lines
editors/
animation/
12 lines
22 lines
asset/
intern/
12 lines
gizmo_library/
gizmo_types/
5 lines
include/
7 lines
24 lines
1 line
interface/
4 lines
4 lines
2 lines
17 lines
2 lines
object/
7 lines
render/
1 line
1 line
8 lines
screen/
6 lines
sculpt_paint/
3 lines
space_file/
2 lines
2 lines
1 line
38 lines
2 lines
19 lines
1 line
space_graph/
26 lines
space_image/
6 lines
4 lines
1 line
space_node/
20 lines
23 lines
12 lines
space_outliner/
2 lines
space_sequencer/
5 lines
27 lines
16 lines
space_spreadsheet/
7 lines
25 lines
space_view3d/
20 lines
7 lines
3 lines
2 lines
transform/
3 lines
30 lines
9 lines
24 lines
util/
26 lines
gpencil_modifiers/
intern/
14 lines
gpu/
2 lines
shaders/
material/
8 lines
40 lines
imbuf/
2 lines
intern/
2 lines
29 lines
makesdna/
9 lines
makesrna/
intern/
1 line
modifiers/
intern/
2 lines
2 lines
4 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
9 lines
2 lines
2 lines
nodes/
composite/
nodes/
2 lines
8 lines
6 lines
6 lines
6 lines
13 lines
6 lines
11 lines
16 lines
6 lines
4 lines
2 lines
6 lines
6 lines
2 lines
12 lines
4 lines
2 lines
20 lines
20 lines
20 lines
20 lines
6 lines
1 line
8 lines
4 lines
6 lines
10 lines
2 lines
7 lines
function/
nodes/
legacy/
8 lines
12 lines
6 lines
8 lines
4 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
26 lines
9 lines
10 lines
8 lines
4 lines
6 lines
geometry/
nodes/
legacy/
12 lines
24 lines
8 lines
18 lines
24 lines
8 lines
8 lines
16 lines
30 lines
18 lines
26 lines
10 lines
20 lines
10 lines
14 lines
10 lines
22 lines
30 lines
6 lines
6 lines
6 lines
6 lines
6 lines
8 lines
8 lines
8 lines
10 lines
8 lines
6 lines
12 lines
12 lines
18 lines
10 lines
8 lines
8 lines
14 lines
26 lines
8 lines
8 lines
14 lines
26 lines
6 lines
42 lines
10 lines
8 lines
24 lines
4 lines
13 lines
4 lines
10 lines
2 lines
4 lines
2 lines
18 lines
18 lines
10 lines
18 lines
38 lines
18 lines
16 lines
13 lines
8 lines
17 lines
6 lines
6 lines
6 lines
10 lines
14 lines
15 lines
8 lines
20 lines
6 lines
13 lines
4 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
36 lines
10 lines
2 lines
4 lines
8 lines
4 lines
6 lines
17 lines
13 lines
22 lines
10 lines
6 lines
12 lines
8 lines
6 lines
6 lines
10 lines
16 lines
6 lines
12 lines
11 lines
38 lines
4 lines
53 lines
15 lines
12 lines
14 lines
8 lines
13 lines
8 lines
8 lines
27 lines
8 lines
13 lines
10 lines
8 lines
8 lines
8 lines
6 lines
30 lines
8 lines
88 lines
35 lines
10 lines
10 lines
6 lines
12 lines
12 lines
shader/
nodes/
8 lines
22 lines
14 lines
14 lines
8 lines
16 lines
16 lines
24 lines
12 lines
6 lines
6 lines
10 lines
18 lines
16 lines
22 lines
18 lines
8 lines
10 lines
2 lines
12 lines
12 lines
texture/
nodes/
1 line
python/
generic/
4 lines
shader_fx/
intern/
2 lines
windowmanager/
intern/
14 lines
2 lines
xr/
intern/
2 lines
Diff 44271
View Options
intern/cycles/blender/addon/engine.py
View Options
intern/cycles/blender/addon/presets.py
View Options
intern/cycles/blender/addon/properties.py
View Options
intern/cycles/blender/addon/version_update.py
View Options
intern/cycles/blender/camera.cpp
View Options
intern/cycles/blender/curves.cpp
View Options
intern/cycles/blender/python.cpp
View Options
intern/cycles/blender/sync.cpp
View Options
intern/cycles/device/cpu/device_impl.cpp
View Options
intern/cycles/device/cuda/device_impl.cpp
View Options
intern/cycles/device/hip/device_impl.cpp
View Options
intern/cycles/device/optix/device_impl.cpp
View Options
intern/cycles/integrator/denoiser.cpp
View Options
intern/cycles/integrator/path_trace_work_gpu.cpp
View Options
intern/cycles/kernel/integrator/shadow_state_template.h
View Options
intern/cycles/kernel/integrator/state_template.h
View Options
intern/cycles/kernel/osl/shaders/node_musgrave_texture.osl
View Options
intern/cycles/kernel/osl/shaders/node_noise.h
View Options
intern/cycles/kernel/svm/fractal_noise.h
View Options
intern/cycles/kernel/svm/musgrave.h
View Options
intern/cycles/scene/constant_fold.cpp
View Options
intern/cycles/scene/geometry.cpp
View Options
intern/cycles/scene/shader_nodes.cpp
View Options
intern/cycles/scene/svm.cpp
View Options
intern/cycles/session/buffers.cpp
View Options
intern/cycles/test/render_graph_finalize_test.cpp
View Options
intern/cycles/util/debug.h
View Options
intern/cycles/util/debug.cpp
View Options
intern/locale/boost_locale_wrapper.cpp
View Options
intern/locale/osx_user_locale.mm
View Options
release/scripts/modules/bl_i18n_utils/settings.py
View Options
release/scripts/modules/bl_i18n_utils/utils_spell_check.py
View Options
release/scripts/presets/keyconfig/keymap_data/blender_default.py
View Options
release/scripts/presets/keyconfig/keymap_data/industry_compatible_data.py
View Options
release/scripts/startup/bl_operators/presets.py
View Options
release/scripts/startup/bl_operators/spreadsheet.py
View Options
release/scripts/startup/bl_ui/space_filebrowser.py
View Options
release/scripts/startup/bl_ui/space_sequencer.py
View Options
release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
View Options
source/blender/blenkernel/BKE_appdir.h
View Options
source/blender/blenkernel/BKE_attribute_access.hh
View Options
source/blender/blenkernel/BKE_global.h
View Options
source/blender/blenkernel/BKE_image.h
View Options
source/blender/blenkernel/BKE_spline.hh
View Options
source/blender/blenkernel/intern/appdir.c
View Options
source/blender/blenkernel/intern/attribute_access.cc
View Options
source/blender/blenkernel/intern/attribute_access_intern.hh
View Options
source/blender/blenkernel/intern/camera.c
View Options
source/blender/blenkernel/intern/curve_eval.cc
View Options
source/blender/blenkernel/intern/curve_to_mesh_convert.cc
View Options
source/blender/blenkernel/intern/geometry_component_curve.cc
View Options
source/blender/blenkernel/intern/geometry_component_instances.cc
View Options
source/blender/blenkernel/intern/geometry_component_mesh.cc
View Options
source/blender/blenkernel/intern/image.c
View Options
source/blender/blenkernel/intern/image_gpu.c
View Options
source/blender/blenkernel/intern/movieclip.c
View Options
source/blender/blenkernel/intern/node.cc
View Options
source/blender/blenkernel/intern/object.c
View Options
source/blender/blenkernel/intern/screen.c
View Options
source/blender/blenkernel/intern/spline_base.cc
View Options
source/blender/blenkernel/intern/texture.c
View Options
source/blender/blenlib/BLI_string_ref.hh
View Options
source/blender/blenlib/BLI_winstuff.h
View Options
source/blender/blenlib/intern/noise.cc
View Options
source/blender/blenlib/intern/path_util.c
View Options
source/blender/blenlib/intern/winstuff.c
View Options
source/blender/blenloader/intern/readfile.c
View Options
source/blender/blenloader/intern/versioning_260.c
View Options
source/blender/blenloader/intern/versioning_280.c
View Options
source/blender/blenloader/intern/versioning_290.c
View Options
source/blender/blenloader/intern/versioning_300.c
View Options
source/blender/blenloader/intern/versioning_common.h
View Options
source/blender/blenloader/intern/versioning_common.cc
View Options
source/blender/blenloader/intern/versioning_legacy.c
View Options
source/blender/compositor/operations/COM_ViewerOperation.cc
View Options
source/blender/depsgraph/intern/depsgraph_eval.cc
View Options
source/blender/depsgraph/intern/eval/deg_eval.cc
View Options
source/blender/draw/engines/basic/basic_engine.c
View Options
source/blender/draw/engines/basic/shaders/depth_vert.glsl
View Options
source/blender/draw/engines/gpencil/gpencil_draw_data.c
View Options
source/blender/draw/engines/image/image_engine.c
View Options
source/blender/draw/intern/draw_view.c
View Options
source/blender/editors/animation/fmodifier_ui.c
View Options
source/blender/editors/animation/keyframes_draw.c
View Options
source/blender/editors/asset/intern/asset_mark_clear.cc
View Options
source/blender/editors/gizmo_library/gizmo_types/snap3d_gizmo.c
View Options
source/blender/editors/include/ED_transform.h
View Options
source/blender/editors/include/ED_transform_snap_object_context.h
View Options
source/blender/editors/include/ED_view3d.h
View Options
source/blender/editors/interface/interface.c
View Options
source/blender/editors/interface/interface_context_menu.c
View Options
source/blender/editors/interface/interface_layout.c
View Options
source/blender/editors/interface/interface_templates.c
View Options
source/blender/editors/interface/tree_view.cc
View Options
source/blender/editors/object/object_bake_api.c
View Options
source/blender/editors/render/render_internal.c
View Options
source/blender/editors/render/render_opengl.c
View Options
source/blender/editors/render/render_preview.c
View Options
source/blender/editors/screen/screen_user_menu.c
View Options
source/blender/editors/sculpt_paint/paint_image_2d.c
View Options
source/blender/editors/space_file/asset_catalog_tree_view.cc
View Options
source/blender/editors/space_file/file_draw.c
View Options
source/blender/editors/space_file/file_intern.h
View Options
source/blender/editors/space_file/file_ops.c
View Options
source/blender/editors/space_file/file_panels.c
View Options
source/blender/editors/space_file/fsmenu.c
View Options
source/blender/editors/space_file/space_file.c
View Options
source/blender/editors/space_graph/graph_buttons.c
View Options
source/blender/editors/space_image/image_buttons.c
View Options
source/blender/editors/space_image/image_ops.c
View Options
source/blender/editors/space_image/image_undo.c
View Options
source/blender/editors/space_node/drawnode.cc
View Options
source/blender/editors/space_node/node_draw.cc
View Options
source/blender/editors/space_node/node_intern.h
View Options
source/blender/editors/space_outliner/outliner_dragdrop.c
View Options
source/blender/editors/space_sequencer/sequencer_draw.c
Loading...
View Options
source/blender/editors/space_sequencer/sequencer_thumbnails.c
Loading...
View Options
source/blender/editors/space_sequencer/space_sequencer.c
View Options
source/blender/editors/space_spreadsheet/space_spreadsheet.cc
View Options
source/blender/editors/space_spreadsheet/spreadsheet_context.cc
View Options
source/blender/editors/space_view3d/view3d_cursor_snap.c
View Options
source/blender/editors/space_view3d/view3d_edit.c
View Options
source/blender/editors/space_view3d/view3d_placement.c
View Options
source/blender/editors/space_view3d/view3d_snap.c
View Options
source/blender/editors/transform/transform_convert.c
View Options
source/blender/editors/transform/transform_gizmo_3d.c
View Options
source/blender/editors/transform/transform_mode.c
View Options
source/blender/editors/transform/transform_snap_object.c
View Options
source/blender/editors/util/ed_draw.c
View Options
source/blender/gpencil_modifiers/intern/MOD_gpencillineart.c
View Options
source/blender/gpu/GPU_state.h
View Options
source/blender/gpu/shaders/material/gpu_shader_material_fractal_noise.glsl
View Options
source/blender/gpu/shaders/material/gpu_shader_material_tex_musgrave.glsl
View Options
source/blender/imbuf/IMB_moviecache.h
View Options
source/blender/imbuf/intern/colormanagement.c
View Options
source/blender/imbuf/intern/moviecache.c
View Options
source/blender/makesdna/DNA_image_types.h
View Options
source/blender/makesrna/intern/rna_image_api.c
View Options
source/blender/modifiers/intern/MOD_cloth.c
View Options
source/blender/modifiers/intern/MOD_collision.c
View Options
source/blender/modifiers/intern/MOD_decimate.c
View Options
source/blender/modifiers/intern/MOD_dynamicpaint.c
View Options
source/blender/modifiers/intern/MOD_fluid.c
View Options
source/blender/modifiers/intern/MOD_nodes.cc
View Options
source/blender/modifiers/intern/MOD_ocean.c
View Options
source/blender/modifiers/intern/MOD_particlesystem.c
View Options
source/blender/modifiers/intern/MOD_remesh.c
View Options
source/blender/modifiers/intern/MOD_softbody.c
View Options
source/blender/modifiers/intern/MOD_subsurf.c
View Options
source/blender/modifiers/intern/MOD_surface.c
View Options
source/blender/modifiers/intern/MOD_ui_common.c
View Options
source/blender/nodes/composite/nodes/node_composite_bokehimage.cc
View Options
source/blender/nodes/composite/nodes/node_composite_brightness.cc
View Options
source/blender/nodes/composite/nodes/node_composite_colorbalance.cc
View Options
source/blender/nodes/composite/nodes/node_composite_colorcorrection.cc
View Options
source/blender/nodes/composite/nodes/node_composite_composite.cc
View Options
source/blender/nodes/composite/nodes/node_composite_curves.cc
View Options
source/blender/nodes/composite/nodes/node_composite_exposure.cc
View Options
source/blender/nodes/composite/nodes/node_composite_gamma.cc
View Options
source/blender/nodes/composite/nodes/node_composite_hueSatVal.cc
View Options
source/blender/nodes/composite/nodes/node_composite_huecorrect.cc
View Options
source/blender/nodes/composite/nodes/node_composite_idMask.cc
View Options
source/blender/nodes/composite/nodes/node_composite_image.cc
View Options
source/blender/nodes/composite/nodes/node_composite_invert.cc
View Options
source/blender/nodes/composite/nodes/node_composite_levels.cc
View Options
source/blender/nodes/composite/nodes/node_composite_mask.cc
View Options
source/blender/nodes/composite/nodes/node_composite_movieclip.cc
View Options
source/blender/nodes/composite/nodes/node_composite_premulkey.cc
View Options
source/blender/nodes/composite/nodes/node_composite_rgb.cc
View Options
source/blender/nodes/composite/nodes/node_composite_sepcombHSVA.cc
View Options
source/blender/nodes/composite/nodes/node_composite_sepcombRGBA.cc
View Options
source/blender/nodes/composite/nodes/node_composite_sepcombYCCA.cc
View Options
source/blender/nodes/composite/nodes/node_composite_sepcombYUVA.cc
View Options
source/blender/nodes/composite/nodes/node_composite_setalpha.cc
View Options
source/blender/nodes/composite/nodes/node_composite_splitViewer.cc
View Options
source/blender/nodes/composite/nodes/node_composite_texture.cc
View Options
source/blender/nodes/composite/nodes/node_composite_tonemap.cc
View Options
source/blender/nodes/composite/nodes/node_composite_trackpos.cc
View Options
source/blender/nodes/composite/nodes/node_composite_valToRgb.cc
View Options
source/blender/nodes/composite/nodes/node_composite_value.cc
View Options
source/blender/nodes/composite/nodes/node_composite_viewer.cc
View Options
source/blender/nodes/function/nodes/legacy/node_fn_random_float.cc
View Options
source/blender/nodes/function/nodes/node_fn_align_euler_to_vector.cc
View Options
source/blender/nodes/function/nodes/node_fn_boolean_math.cc
View Options
source/blender/nodes/function/nodes/node_fn_float_compare.cc
View Options
source/blender/nodes/function/nodes/node_fn_float_to_int.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_bool.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_color.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_int.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_special_characters.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_string.cc
View Options
source/blender/nodes/function/nodes/node_fn_input_vector.cc
View Options
source/blender/nodes/function/nodes/node_fn_random_value.cc
View Options
source/blender/nodes/function/nodes/node_fn_replace_string.cc
View Options
source/blender/nodes/function/nodes/node_fn_rotate_euler.cc
View Options
source/blender/nodes/function/nodes/node_fn_slice_string.cc
View Options
source/blender/nodes/function/nodes/node_fn_string_length.cc
View Options
source/blender/nodes/function/nodes/node_fn_value_to_string.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_align_rotation_to_vector.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_clamp.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_color_ramp.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_combine_xyz.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_compare.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_convert.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_curve_map.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_fill.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_map_range.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_math.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_mix.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_proximity.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_randomize.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_sample_texture.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_separate_xyz.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_transfer.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_vector_math.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_attribute_vector_rotate.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_endpoints.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_reverse.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_select_by_handle_type.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_set_handles.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_spline_type.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_subdivide.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_curve_to_points.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_delete_geometry.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_edge_split.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_material_assign.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_mesh_to_curve.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_distribute.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_instance.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_rotate.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_scale.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_separate.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_point_translate.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_points_to_volume.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_raycast.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_select_by_material.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_subdivision_surface.cc
View Options
source/blender/nodes/geometry/nodes/legacy/node_geo_volume_to_mesh.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_attribute_capture.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_attribute_remove.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_attribute_statistic.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_boolean.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_bounding_box.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_collection_info.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_convex_hull.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_endpoint_selection.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_fill.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_fillet.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_handle_type_selection.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_length.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_parameter.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_bezier_segment.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_circle.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_line.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_quadratic_bezier.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_quadrilateral.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_spiral.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_star.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_reverse.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_sample.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_set_handles.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_spline_type.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_subdivide.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_to_mesh.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_to_points.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_curve_trim.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_delete_geometry.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_distribute_points_on_faces.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_edge_split.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_image_texture.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_curve_handles.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_curve_tilt.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_id.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_index.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_material.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_material_index.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_normal.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_position.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_radius.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_shade_smooth.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_spline_cyclic.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_spline_length.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_spline_resolution.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_input_tangent.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_instance_on_points.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_instances_to_points.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_is_viewport.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_material_replace.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_material_selection.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_circle.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cone.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cube.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_cylinder.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_grid.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_ico_sphere.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_line.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_primitive_uv_sphere.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_subdivide.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_to_curve.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_mesh_to_points.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_object_info.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_points_to_vertices.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_points_to_volume.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_proximity.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_raycast.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_realize_instances.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_rotate_instances.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_scale_instances.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_separate_components.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_separate_geometry.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_curve_handles.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_curve_radius.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_curve_tilt.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_id.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_material.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_material_index.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_point_radius.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_position.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_shade_smooth.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_spline_cyclic.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_set_spline_resolution.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_string_join.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_string_to_curves.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_subdivision_surface.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_switch.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_transfer_attribute.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_transform.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_translate_instances.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_triangulate.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_viewer.cc
View Options
source/blender/nodes/geometry/nodes/node_geo_volume_to_mesh.cc
View Options
source/blender/nodes/shader/nodes/node_shader_clamp.cc
View Options
source/blender/nodes/shader/nodes/node_shader_curves.cc
View Options
source/blender/nodes/shader/nodes/node_shader_map_range.cc
View Options
source/blender/nodes/shader/nodes/node_shader_math.cc
View Options
source/blender/nodes/shader/nodes/node_shader_mixRgb.cc
View Options
source/blender/nodes/shader/nodes/node_shader_sepcombRGB.cc
View Options
source/blender/nodes/shader/nodes/node_shader_sepcombXYZ.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_brick.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_checker.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_gradient.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_image.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_magic.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_musgrave.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_noise.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_voronoi.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_wave.cc
View Options
source/blender/nodes/shader/nodes/node_shader_tex_white_noise.cc
View Options
source/blender/nodes/shader/nodes/node_shader_valToRgb.cc
View Options
source/blender/nodes/shader/nodes/node_shader_value.cc
View Options
source/blender/nodes/shader/nodes/node_shader_vector_math.cc
View Options
source/blender/nodes/shader/nodes/node_shader_vector_rotate.cc
View Options
source/blender/nodes/texture/nodes/node_texture_image.c
View Options
source/blender/python/generic/idprop_py_ui_api.c
View Options
source/blender/shader_fx/intern/FX_ui_common.c
View Options
source/blender/windowmanager/intern/wm_files.c
View Options
source/blender/windowmanager/intern/wm_splash_screen.c
View Options
source/blender/windowmanager/xr/intern/wm_xr_operators.c