UI: Use socket type info color to draw links
ClosedPublic
Actions

Authored by Omar Emara (OmarSquircleArt) on Oct 30 2021, 12:42 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB980bc5a70755: UI: Use socket type info color to draw links

Summary

Currently, colored links overlay only supports standard sockets defined
by Blender. Some add-ons like Animation Nodes defines custom sockets for
everything and hence doesn't get colored sockets.

This patch uses the draw color from the socket type info to draw links
in order to support custom sockets.

Diff Detail

Repository

rB Blender

Branch

custom-socket-overlay-draw-color (branched from master)

Build Status

Buildable 18334
Build 18334: arc lint + arc unit

Event Timeline

Omar Emara (OmarSquircleArt) created this revision.Oct 30 2021, 12:42 PM

Harbormaster completed remote builds in B18334: Diff 44140.Oct 30 2021, 12:42 PM

Omar Emara (OmarSquircleArt) requested review of this revision.Oct 30 2021, 12:42 PM

Hans Goudey (HooglyBoogly) added inline comments.Nov 1 2021, 11:07 PM

source/blender/editors/space_node/drawnode.cc
4319	Maybe it makes a little more sense to have the const cast in one place: `node_socket_color_get`. Eventually I'd hope the function in the type info could get a const context argument.