Page MenuHome

Pointcloud selection support
ClosedPublic

Authored by Jarrett Johnson (jarrett.johnson) on Nov 1 2021, 6:08 AM.

Details

Summary

This patch adds support for selecting pointclouds.

Since pointclouds were not properly drawn to the selection buffer (as diagonsed by output from glReadPixels and Renderdoc), they were not able to be selectable by depth picking or occlusion queries. In basic_engine, objects were rendered with a shader which draws to a depth buffer but only assumes a single position vertex attribute. Pointclouds, though, require at least another vertex attribute pos_inst which provides the instance offsets. Thus, this patch adds another shader variant for pointclouds which supports these two attributes and renders the points appropriately.

Addresses T92415

Diff Detail

Repository
rB Blender
Branch
point_cloud_selection (branched from master)
Build Status
Buildable 18355
Build 18355: arc lint + arc unit

Event Timeline

Jarrett Johnson (jarrett.johnson) requested review of this revision.Nov 1 2021, 6:08 AM
Jarrett Johnson (jarrett.johnson) created this revision.
This revision is now accepted and ready to land.Nov 1 2021, 11:04 AM

@Clément Foucault (fclem) Can you commit this to the release branch? (I can also do it, but you are the reviewer)

This revision was automatically updated to reflect the committed changes.

Awesome!

one thing: Addons seems to have gotten a change (Subproject commit), please make sure you run make update properly before submitting Diffs

FYI @Jarrett Johnson (jarrett.johnson) , there is T81292: Hair: Support selection (and outlines or alternative vizualisation) in viewport still open [which I never found time for], so if you are interested? Would happily step down from that one...