Page MenuHome
Differential D13064

Geometry Nodes: Add Selection Input to Resample Curves Node
ClosedPublic
Actions

Authored by Johnny Matthews (guitargeek) on Nov 1 2021, 11:39 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Jacques Lucke (JacquesLucke)
Commits
rBa7672caeb255: Geometry Nodes: Add Selection Input to Resample Curves Node
Summary

Add a per spline selection input field to determine which splines will be resampled.

Diff Detail

Repository
rB Blender
Branch
resample_pick (branched from master)
Build Status
Buildable 18376
Build 18376: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Nov 1 2021, 11:39 PM
Johnny Matthews (guitargeek) created this revision.
Harbormaster completed remote builds in B18375: Diff 44215.Nov 1 2021, 11:39 PM
Johnny Matthews (guitargeek) added a reviewer: Hans Goudey (HooglyBoogly).Nov 1 2021, 11:40 PM
Johnny Matthews (guitargeek) added a project: Geometry Nodes.
Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 2 2021, 1:15 AM

Good idea, just some smaller comments inline.

source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc
79

This one isn't optional I don't think.

212

I'd prefer using get_evaluated_as_mask here.

239

Does this mode not need a copy too?

This revision now requires changes to proceed.Nov 2 2021, 1:15 AM
Johnny Matthews (guitargeek) updated this revision to Diff 44218.Nov 2 2021, 2:28 AM
Johnny Matthews (guitargeek) marked 3 inline comments as done.
  • Minor updates and omissions
Harbormaster completed remote builds in B18376: Diff 44218.Nov 2 2021, 2:28 AM
Johnny Matthews (guitargeek) edited the summary of this revision. (Show Details)Nov 2 2021, 2:28 AM
Hans Goudey (HooglyBoogly) accepted this revision.Nov 2 2021, 4:03 AM
Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc
44

Unnecessary newline here.

273–274

Could skip the selection variable here, and just assign mode_param.selection.

Johnny Matthews (guitargeek) updated this revision to Diff 44219.Nov 2 2021, 4:10 AM
Johnny Matthews (guitargeek) marked 2 inline comments as done.
  • Minor Cleanup
Harbormaster completed remote builds in B18377: Diff 44219.Nov 2 2021, 4:10 AM
Jacques Lucke (JacquesLucke) accepted this revision.Nov 3 2021, 2:24 PM
This revision is now accepted and ready to land.Nov 3 2021, 2:24 PM
Closed by commit rBa7672caeb255: Geometry Nodes: Add Selection Input to Resample Curves Node (authored by Johnny Matthews (guitargeek)). · Explain WhyNov 3 2021, 5:56 PM
This revision was automatically updated to reflect the committed changes.
Johnny Matthews (guitargeek) added a commit: rBa7672caeb255: Geometry Nodes: Add Selection Input to Resample Curves Node.
Wilsimar (wilBr) awarded a token.Nov 3 2021, 8:09 PM
Wilsimar (wilBr) added a subscriber: Wilsimar (wilBr).Nov 3 2021, 8:13 PM

@Johnny Matthews (guitargeek) thank you...

I think selection segments can be very useful too... like resampling without lost corner knots.

Hans Goudey (HooglyBoogly) added a comment.Nov 4 2021, 2:43 PM
In D13064#345582, @Wilsimar (wilBr) wrote:

I think selection segments can be very useful too... like resampling without lost corner knots.

That would probably be a different sample method.

Revision Contents
Changeset List

PathSize
source/
blender/
nodes/
geometry/
nodes/
47 lines

Diff 44218

View Options

source/blender/nodes/geometry/nodes/node_geo_curve_resample.cc

Loading...