Page MenuHome
Differential D13071

Geometry Nodes: Improve curve point attribute assert
ClosedPublic
Actions

Authored by Hans Goudey (HooglyBoogly) on Nov 2 2021, 5:23 PM.

Details

Reviewers
Jacques Lucke (JacquesLucke)
Commits
rBa72ed0bb7faf: Cleanup: Improve curve point attribute assert
Summary

This properly checks the order of point domain attributes on each
spline, and avoids the map, which makes the code easier to understand.

Diff Detail

Repository
rB Blender

Event Timeline

Hans Goudey (HooglyBoogly) requested review of this revision.Nov 2 2021, 5:23 PM
Hans Goudey (HooglyBoogly) created this revision.
Harbormaster completed remote builds in B18395: Diff 44254.Nov 2 2021, 5:23 PM
Hans Goudey (HooglyBoogly) added a reviewer: Jacques Lucke (JacquesLucke).Nov 2 2021, 5:24 PM
Hans Goudey (HooglyBoogly) added a project: Geometry Nodes.
Jacques Lucke (JacquesLucke) accepted this revision.Nov 2 2021, 6:19 PM

Should obviously only be committed after T92652 is fixed.

This revision is now accepted and ready to land.Nov 2 2021, 6:19 PM
Closed by commit rBa72ed0bb7faf: Cleanup: Improve curve point attribute assert (authored by Hans Goudey (HooglyBoogly)). · Explain WhyNov 2 2021, 9:23 PM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rBa72ed0bb7faf: Cleanup: Improve curve point attribute assert.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
40 lines
1 line
nodes/
geometry/
nodes/
1 line

Diff 44270

View Options

source/blender/blenkernel/intern/curve_eval.cc

Loading...
View Options

source/blender/blenkernel/intern/geometry_set_instances.cc

Loading...
View Options

source/blender/nodes/geometry/nodes/node_geo_join_geometry.cc

Loading...