Page MenuHome

VSE: Remove separator lines between rows
ClosedPublic

Authored by Pablo Vazquez (pablovazquez) on Nov 2 2021, 6:46 PM.

Details

Summary

The VSE grid theme setting is currently used for two things:

  • Indicate time intervals (vertical lines)
  • As separator between channels (horizontal lines)

This adds visual noise because for the time interval to be visible, the
grid color needs to be bright, resulting in a rectangle-grid backdrop.

Recently, the VSE got a theme setting to customize alternate-row background color.
This should be sufficient to tell the channels apart without the need for a line in between.

Additionally, this patch makes the VSE background use the theme setting as-is,
without hard-coded darkening, to ease the tweaking of themes. This aligns the style
of the VSE backdrop with the rest of Blender (Outliner rows, File Browser, Spreadsheet,
Info and animation editors).

Related reports: T92581
Related task: T92792

Before

After

Diff Detail

Repository
rB Blender

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Nov 2 2021, 6:46 PM
Pablo Vazquez (pablovazquez) created this revision.
Pablo Vazquez (pablovazquez) edited the summary of this revision. (Show Details)
  • Match background color with current theme color.

The column on the left of the screenshots with the channel numbers looks very dark now, does that need another theme change, or is it actually consistent to elsewhere and just looking weird to me?

The column on the left of the screenshots with the channel numbers looks very dark now, does that need another theme change, or is it actually consistent to elsewhere and just looking weird to me?

That is actually the "out of frame range" area (before start frame, after end frame).

It's hardcoded to be a -25 shade of TH_BACK, which seems much but (before this patch) made sense since the editor backdrop itself was offset -25 (and was semi transparent).
It was basically applying an offset for the already-offset background color.

Since this patch makes the backdrop use the pure TH_BACK color from the theme without offsets, I think we can tone the out of frame range down to prevent it going too dark.

The following screenshot changes the out of frame range to be -10, seems to be a good sweet spot:

Much better! Thanks for the explanation.

  • Adjust the darkness of the out-of-range. No need to darken it so much anymore.

Existing files seem to have weird color, I need to load factory defaults for this patch to look as intended. Unless this weird look is intended, which I wouldn't dispute, but I like daker one much better.

Otherwise seems fine.

Julian Eisel (Severin) requested changes to this revision.Nov 5 2021, 11:25 AM

Yup, this will need versioning.

This revision now requires changes to proceed.Nov 5 2021, 11:25 AM

This patch is part of a number of fixes to the default theme (other tweaks in D13087). Once approved, I plan to do the versioning to update it all at once so we avoid upping the file subversion twice.

Alright, if committed together with D13087, this is fine.

This revision is now accepted and ready to land.Nov 5 2021, 2:48 PM