Paths

Table of Contentst

Differential D13073

UI: Fix UIList item using "regular" widget colors while edited
ClosedPublic
Actions

Authored by Pablo Vazquez (pablovazquez) on Nov 2 2021, 7:26 PM.

Details

Reviewers

Julian Eisel (Severin)

Group Reviewers

User Interface

Maniphest Tasks

T92720: UI: Some Values have too bright selection since new UI

Commits

rB9e71a0754738: UI: Fix UIList item using "regular" widget colors while edited

Summary

Simply removing the check for UI_STATE_TEXT_INPUT makes it inherit
the "List Item" User Interface theme settings. This patch changes the
default theme to match the colors of text input fields.

Master

This patch

All the included commmunity themes seem to work well (only Deep Grey might
need more contrast but that's a different patch).

Related reports: T92720

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Nov 2 2021, 7:26 PM

Pablo Vazquez (pablovazquez) created this revision.

Harbormaster completed remote builds in B18401: Diff 44261.Nov 2 2021, 7:26 PM

Pablo Vazquez (pablovazquez) edited the summary of this revision. (Show Details)Nov 2 2021, 7:28 PM

Pablo Vazquez (pablovazquez) added a reviewer: User Interface.

Pablo Vazquez (pablovazquez) mentioned this in T92792: UI: Theme fixes.Nov 3 2021, 4:09 PM

Dalai Felinto (dfelinto) added a task: T92720: UI: Some Values have too bright selection since new UI.Nov 3 2021, 4:46 PM

Makes sense and should be fine. Just one small code style correction to do, no need to re-review after that.

source/blender/editors/interface/interface_widgets.c
2529	Remove superfluous parentheses.

This revision is now accepted and ready to land.Nov 4 2021, 3:25 PM

Remove superfluous parenthesis

Harbormaster completed remote builds in B18474: Diff 44367.Nov 4 2021, 3:29 PM

Pablo Vazquez (pablovazquez) added inline comments.Nov 4 2021, 3:29 PM

source/blender/editors/interface/interface_widgets.c
2529	Oops, relying too much in clang to fix things for me :D Thanks!

Closed by commit rB9e71a0754738: UI: Fix UIList item using "regular" widget colors while edited (authored by Pablo Vazquez (pablovazquez)). · Explain WhyNov 4 2021, 3:32 PM

This revision was automatically updated to reflect the committed changes.

Pablo Vazquez (pablovazquez) added a commit: rB9e71a0754738: UI: Fix UIList item using "regular" widget colors while edited.

Pablo Vazquez (pablovazquez) marked an inline comment as done.Nov 4 2021, 5:21 PM

Revision Contents
Changeset List

Path

Size

release/

datafiles/

userdef/

userdef_default_theme.c

2 lines

source/

blender/

editors/

interface/

interface_widgets.c

2 lines

Diff 44368

View Options

release/datafiles/userdef/userdef_default_theme.c