Fix: Make sure geometry set owns mesh before taking ownership.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 2 2021, 7:58 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)

Commits

rB2b12b4cd7dcc: Fix: make sure geometry owns mesh before taking ownership

Summary

This fixes the second problem that I found in T91838#1246902.

The problem was that the mesh in the output of the Object Info node was not owned by the geometry set (it indirectly calls add_final_mesh_as_geometry_component).
This lead to some other issues down the line.

Diff Detail

Repository

rB Blender

Branch

object-info-mesh-ownership-bug (branched from master)

Build Status

Buildable 18404
Build 18404: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 2 2021, 7:58 PM

Jacques Lucke (JacquesLucke) created this revision.

Harbormaster completed remote builds in B18404: Diff 44264.Nov 2 2021, 7:58 PM

Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 2 2021, 8:00 PM

Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).

I wonder if a release_owned function will help us avoid this problem elsewhere in the future. Then again, the real solution is to stop constantly adding and removing the mesh from the geometry set in the modifier stack-- like curves and point clouds do it.

This revision is now accepted and ready to land.Nov 2 2021, 8:49 PM

Closed by commit rB2b12b4cd7dcc: Fix: make sure geometry owns mesh before taking ownership (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 3 2021, 10:46 AM

This revision was automatically updated to reflect the committed changes.

Jacques Lucke (JacquesLucke) added a commit: rB2b12b4cd7dcc: Fix: make sure geometry owns mesh before taking ownership.