Page MenuHome

Fix T91405: Block artefacts in WEBM video
ClosedPublic

Authored by Richard Antalik (ISS) on Nov 3 2021, 3:42 AM.

Details

Summary

Issue was caused by incorrect FFmpeg asynchronous decoding API. In most
cases, decoder returns 1 frame each time it is fed by 1 packet. Here
decoder wanted to return more frames, but our code always expected only
one.

Before sending new packets to decoder, check if there are frames to
receive. If there are, process them, otherwise continue decoding as
usual.

Diff Detail

Repository
rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 3 2021, 3:42 AM
Richard Antalik (ISS) created this revision.
  • Remove unused include

Other than my nitpicks, LGTM!

source/blender/imbuf/intern/anim_movie.c
987–988

Somewhat unrelated to the patch, but I guess you can remove this as this statement doesn't really do anything?
The value will be overwritten below.

1001–1002

Same as above.

This revision is now accepted and ready to land.Nov 3 2021, 11:21 AM
This revision was automatically updated to reflect the committed changes.