Fix T91992: Incorrect clip strip image size
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 3 2021, 8:55 AM.

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T91992: Proxy Render Size is cropping instead of lowering down the resolution

Commits

rBef8240e64c9f: Fix T91992: Incorrect clip strip image size

Summary

When proxy size lower than 100% is used, clip strips are rendered with
incorrect image size.

This is because if proxies aren't enabled in movieclip, it automatically
falls back on rendering original media. Sequencer doesn't have knowledge
about this and since 9c99292a16df it assumes that image is proxy,
because it explicitly requested this size.

Check movieclip flag to see if proxies are enabled.

This is probably not great solution, but not sure if there is better one, which would not require sequencer to care about how movieclip rendering works.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) created this revision.Nov 3 2021, 8:55 AM

Harbormaster completed remote builds in B18417: Diff 44283.Nov 3 2021, 8:55 AM

Fix whitespace

Harbormaster completed remote builds in B18418: Diff 44284.Nov 3 2021, 8:57 AM

Richard Antalik (ISS) added inline comments.Nov 3 2021, 9:01 AM

source/blender/sequencer/intern/render.c
1181–1182	Just to clarify this logic: If clip uses proxies, proxy size is explicitly requested, image is returned only if proxy is built, otherwise `NULL`. If clip doesn't use proxies, proxy size is explicitly requested, it falls back on full size render - I did not expect that.