Cycles: Add sample offset option
ClosedPublic
Actions

Authored by Andrii Symkin (pembem22) on Nov 3 2021, 12:43 PM.

Details

Reviewers

William Leeson (leesonw)

Commits

rBc63e735f6b60: Cycles: Add sample offset option

Summary

This patch exposes the sampling offset option to Blender. It is located in the "Sampling > Advanced" panel.
For example, this can be useful to parallelize rendering and distribute different chunks of samples for each computer to render.

I also had to add this option to RenderWork and RenderScheduler classes so that the sample count in the status string can be calculated correctly.

Diff Detail

Repository

rB Blender

Branch

cycles-x-sample-offset

Build Status

Buildable 18443
Build 18443: arc lint + arc unit

Event Timeline

Andrii Symkin (pembem22) requested review of this revision.Nov 3 2021, 12:43 PM

Andrii Symkin (pembem22) created this revision.

Harbormaster completed remote builds in B18428: Diff 44300.Nov 3 2021, 12:43 PM

Andrii Symkin (pembem22) added reviewers: Cycles, William Leeson (leesonw).Nov 3 2021, 12:44 PM

Andrii Symkin (pembem22) edited the summary of this revision. (Show Details)Nov 3 2021, 12:46 PM

Brecht Van Lommel (brecht) requested changes to this revision.Nov 3 2021, 1:55 PM

Brecht Van Lommel (brecht) added a subscriber: Brecht Van Lommel (brecht).

Brecht Van Lommel (brecht) added inline comments.

intern/cycles/blender/addon/ui.py
243	Move it to the Advanced panel, this is not something that users should be tweaking often manually.
intern/cycles/blender/sync.cpp
847–849	The clamping should be the other way around I think, seems better to render fewer samples than lower the sample offset and rendering the same sample multiple times. params.sample_offset = clamp(params.sample_offset, 0, Integrator::MAX_SAMPLES); params.samples = clamp(params.samples, 0, Integrator::MAX_SAMPLES - params.sample_offset);
intern/cycles/kernel/film/accumulate.h
148	This should be `sample + start_sample`.

This revision now requires changes to proceed.Nov 3 2021, 1:55 PM

Move Sample Offset option to the Advanced panel
Clamp sample count instead of sample offset
Fix incorrect order of samples when sample count layer is enabled

Harbormaster completed remote builds in B18443: Diff 44323.Nov 3 2021, 6:30 PM

There were some issues with the order of samples when the sample count layer was enabled. The reason was the sample_start value from the KernelWorkTile class, which I assumed to be constant, but in my case it was being increased during sampling. When added to the value from sample count layer, the resulting value was increased by 2 every sample.

So I've added sample_offset to the KernelWorkTile as well. I've done some tests with different combinations of sample counts and offsets, with and without sample count layer, and the results are correct.

intern/cycles/kernel/film/accumulate.h
148	Sample offset is already accounted for in the `sample` variable.

Fix start_sample_ used instead of sample_offset_

Harbormaster completed remote builds in B18445: Diff 44326.Nov 3 2021, 6:52 PM

Jack Grzes (jacek007g) awarded a token.Nov 4 2021, 10:23 AM

Andrii Symkin (pembem22) edited the summary of this revision. (Show Details)Nov 7 2021, 8:05 PM

Alaska (Alaska) awarded a token.Nov 7 2021, 9:13 PM

Jeducious (jameshcrowther) awarded a token.Nov 7 2021, 9:51 PM

This looks good to me and from my checks the samples seem to start at the correct values.

Do you need me to commit this?

Yes, I don't have commit rights. Thanks!

Brecht Van Lommel (brecht) removed a reviewer: Brecht Van Lommel (brecht).Nov 9 2021, 2:26 PM

Brecht Van Lommel (brecht) removed a reviewer: Cycles.

This revision is now accepted and ready to land.Nov 9 2021, 2:26 PM

Hi @William Leeson (leesonw) 😄 just checking in to see if there's anything else I can help with here? I've noticed we're close to getting this patch in, which is great. If there's something you need please let me know!