Updated Addon Themes for Spreadsheet Workspace
ClosedPublic
Actions

Authored by Peter Sergay (psergay) on Nov 3 2021, 5:05 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Harley Acheson (harley)

Commits

rBAd077a9bde03d: Fix T92492: Update Addon Themes for Spreadsheet Workspace

Summary

This is a revision that addresses T92492: Spreadsheet does not change when the theme changes

Problem: The Blender Light, White, Print Friendly, and XSI themes weren't updated to color the Spreadsheet workspace appropriately.

Solution: I updated the themes so that the Spreadsheet would fit into the aesthetic of each theme.

note: I needed to make two separate diffs, one for the addons and one just for the Blender Light theme. I am submitting two revisions in total. This revision targets the addon themes.

XSI before

XSI after

Print Friendly before

Print Friendly after

White before

White after. Note: The text in the blue highlighted areas is a little hard to read. If a reviewer could adjust that before committing, that would be good. I'm happy to tweak it myself if needed.

Diff Detail

Repository: rBA Blender Add-ons

Event Timeline

Peter Sergay (psergay) requested review of this revision.Nov 3 2021, 5:05 PM

Peter Sergay (psergay) created this revision.

Thanks for the patch! I think the panel colors should be updated, for the row filters in the spreadsheet N-panel:

This revision now requires changes to proceed.Nov 5 2021, 10:09 PM

Oh, I didn't realize the spreadsheet had an N panel! I will update the themes to include the row filters.

I updated the themes to include updates to the N panel. While updating the XSI, White, and Print Friendly, I noticed that Minimal Dark also could use an update to its N panel, so I also updated that.
My favorite update is to XSI. I can't include screenshots this time because developer.blender.org is being slow.

Hmm, I'm getting merge conflicts when applying this patch. Could you make sure you've merged the latest blender-v3.0-release branch into your branch? Thanks.

I just updated the source and submodules with Git and remade the diff file, I hope it works now!

Hmm, unfortunately it doesn't. Did you submit the diff with arc? Generally that works better.

Peter Sergay (psergay) mentioned this in T92492: Spreadsheet does not change when the theme changes.Nov 19 2021, 7:22 PM

I'll make a fair amount of changes when committing, so that only the spreadsheet editor theme is affected by the changes.
But since Bcon4 is starting, this needs to be committed now.

This revision is now accepted and ready to land.Nov 24 2021, 6:35 PM

Closed by commit rBAd077a9bde03d: Fix T92492: Update Addon Themes for Spreadsheet Workspace (authored by Peter Sergay (psergay), committed by Hans Goudey (HooglyBoogly)). · Explain WhyNov 24 2021, 6:38 PM

This revision was automatically updated to reflect the committed changes.

Hans Goudey (HooglyBoogly) added a commit: rBAd077a9bde03d: Fix T92492: Update Addon Themes for Spreadsheet Workspace.