Page MenuHome
Differential D13092

Fix Group Output nodes having different padding from Group Input nodes
ClosedPublic
Actions

Authored by Nikhil Shringarpurey (Nikhil.Net) on Nov 3 2021, 6:45 PM.

Details

Reviewers
Julian Eisel (Severin)
Hans Goudey (HooglyBoogly)
Commits
rB26d2caee3ba0: Fix T92268: Group input and output nodes have inconsistent padding
Summary

This patch fixes the bug raised in T92268.

As listed in that bug report, the group output node did not have the same size padding as the group input, leading to the node looking different and actually being smaller.

No one's life was threatened by this bug, but it was an annoying UI papercut that this diff fixes. It works across any use of group nodes (Geometry Nodes, Compositor, Shaders, and so on).

masterpatch

Changed reviewer from group as per ThomasDinges.

Diff Detail

Repository
rB Blender

Event Timeline

Nikhil Shringarpurey (Nikhil.Net) requested review of this revision.Nov 3 2021, 6:45 PM
Nikhil Shringarpurey (Nikhil.Net) created this revision.
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)Nov 9 2021, 8:30 PM
Nikhil Shringarpurey (Nikhil.Net) edited reviewers, added: Julian Eisel (Severin); removed: User Interface.
Leon Schittek (lone_noel) awarded a token.Nov 9 2021, 9:33 PM
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)Nov 9 2021, 11:02 PM
Nikhil Shringarpurey (Nikhil.Net) edited the summary of this revision. (Show Details)Nov 9 2021, 11:27 PM
Nikhil Shringarpurey (Nikhil.Net) added a reviewer: Hans Goudey (HooglyBoogly).Nov 16 2021, 11:41 PM
Hans Goudey (HooglyBoogly) accepted this revision.Nov 18 2021, 4:49 PM

This makes sense to me, I see no reason for the padding not to apply to nodes with no inputs.

This revision is now accepted and ready to land.Nov 18 2021, 4:49 PM
Closed by commit rB26d2caee3ba0: Fix T92268: Group input and output nodes have inconsistent padding (authored by Nikhil Shringarpurey (Nikhil.Net), committed by Hans Goudey (HooglyBoogly)). · Explain WhyDec 2 2021, 4:05 AM
This revision was automatically updated to reflect the committed changes.
Hans Goudey (HooglyBoogly) added a commit: rB26d2caee3ba0: Fix T92268: Group input and output nodes have inconsistent padding.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
4 lines

Diff 44324

View Options

source/blender/editors/space_node/node_draw.cc

Loading...