Page MenuHome
Differential D13099

Fix T90592: Incorrect scrollbar range with backdrop
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 4 2021, 4:07 AM.

Details

Reviewers
Sergey Sharybin (sergey)
Julian Eisel (Severin)
Maniphest Tasks
T90592: VSE: Using Preview as Backdrop will make the vertical scrollbar use insane values
Commits
rBa040d2a93a7d: Fix T90592: Incorrect scrollbar range with backdrop
Summary

v2d->tot rect was set for backdrop drawing. Set range before drawing
scrollbars.

Diff Detail

Repository
rB Blender
Branch
T90592 (branched from master)
Build Status
Buildable 18454
Build 18454: arc lint + arc unit

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 4 2021, 4:07 AM
Richard Antalik (ISS) created this revision.
Harbormaster completed remote builds in B18454: Diff 44342.Nov 4 2021, 4:07 AM
Sergey Sharybin (sergey) added a reviewer: Julian Eisel (Severin).Nov 5 2021, 10:52 AM
Sergey Sharybin (sergey) added a subscriber: Julian Eisel (Severin).

Sounds simple, but is not really my area.
@Julian Eisel (Severin), do you have time to check on this?

Julian Eisel (Severin) accepted this revision.Nov 5 2021, 11:24 AM

Should be fine!

source/blender/editors/space_sequencer/sequencer_draw.c
2817

Suggest making this const.

This revision is now accepted and ready to land.Nov 5 2021, 11:24 AM
Closed by commit rBa040d2a93a7d: Fix T90592: Incorrect scrollbar range with backdrop (authored by Richard Antalik (ISS)). · Explain WhyNov 15 2021, 8:33 PM
This revision was automatically updated to reflect the committed changes.
Richard Antalik (ISS) added a commit: rBa040d2a93a7d: Fix T90592: Incorrect scrollbar range with backdrop.

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_sequencer/
5 lines

Diff 44342

View Options

source/blender/editors/space_sequencer/sequencer_draw.c

Loading...