Page MenuHome

Geometry Nodes: Add Arc Mode to Circle Node
AbandonedPublic

Authored by Johnny Matthews (guitargeek) on Nov 4 2021, 5:43 AM.

Details

Summary

Add an arc mode to the circle node that allows for a start
and and sweep of the arc. As well as a boolean input to
determine if the centerpoint is connected.

Diff Detail

Repository
rB Blender
Branch
arc2 (branched from master)
Build Status
Buildable 18456
Build 18456: arc lint + arc unit

Event Timeline

Johnny Matthews (guitargeek) requested review of this revision.Nov 4 2021, 5:43 AM
Johnny Matthews (guitargeek) created this revision.
  • Merge branch 'master' into arc2
  • Split Arc to Separate Node
  • Merge branch 'master' into arc2
  • update for master
Hans Goudey (HooglyBoogly) requested changes to this revision.Nov 22 2021, 5:14 PM
  • Generally +1 for reusing the code this way, this seems preferable.
  • The patch description and title should be updated now that it's a separate node.
  • In points mode, it seems more useful and intuitive if the start and end angles are calculated automatically.
  • I'm wondering whether having start and end angles as inputs rather than start and "sweep" angles would be a bit more flexible.
source/blender/nodes/geometry/nodes/node_geo_curve_primitive_arc.cc
36–44 ↗(On Diff #45090)

Periods are added automatically to the end of descriptions.

This revision now requires changes to proceed.Nov 22 2021, 5:14 PM

D13640 will take over this task