Differential D13101

Fix T90415: Missing cache invalidation
ClosedPublic
Actions

Authored by Richard Antalik (ISS) on Nov 4 2021, 6:01 AM.

Tags

None

Subscribers

Peter Fog (tintwotin)

Details

Reviewers

Sergey Sharybin (sergey)

Maniphest Tasks

T90415: VSE: Functions missing Cache Invalidation or Preview updates

Commits

rB7e148c45c89a: Fix T90415: Missing cache invalidation

Summary

Some RNA properties and operators did not invalidate cache or did it
incorrectly.

Diff Detail

Repository: rB Blender

Event Timeline

Richard Antalik (ISS) requested review of this revision.Nov 4 2021, 6:01 AM

Richard Antalik (ISS) created this revision.

Harbormaster completed remote builds in B18457: Diff 44345.Nov 4 2021, 6:01 AM

Richard Antalik (ISS) added a reviewer: Sergey Sharybin (sergey).Nov 4 2021, 6:07 AM

On a glance seems fine. But testing and such I'd rely on you here :)

This revision is now accepted and ready to land.Nov 5 2021, 10:54 AM

Closed by commit rB7e148c45c89a: Fix T90415: Missing cache invalidation (authored by Richard Antalik (ISS)). · Explain WhyNov 15 2021, 8:33 PM

This revision was automatically updated to reflect the committed changes.

Richard Antalik (ISS) added a commit: rB7e148c45c89a: Fix T90415: Missing cache invalidation.

Has this part of the report been dealt with in the committed patch?

Scene Strips:
3D View object changes in referenced Scene strip need to invalidate the cache.
Changing the Post Processing setting in the referenced scene in a scene strip needs to invalidate the cache.
Changes in Compositor need to invalidate the cache.

In D13101#349242, @Peter Fog (tintwotin) wrote:

Has this part of the report been dealt with in the committed patch?

Scene Strips:
3D View object changes in referenced Scene strip need to invalidate the cache.
Changing the Post Processing setting in the referenced scene in a scene strip needs to invalidate the cache.
Changes in Compositor need to invalidate the cache.

No, changes in scene itself have currently no method of invalidating cache implemented.

Revision Contents
Changeset List

Path

Size

source/

blender/

editors/

space_sequencer/

sequencer_edit.c

31 lines

makesrna/

intern/

rna_sequencer.c

5 lines

rna_sequencer_api.c

3 lines

sequencer/

SEQ_relations.h

4 lines

1 line

intern/

2 lines

strip_relations.c

74 lines

59 lines

Diff 44773

source/blender/editors/space_sequencer/sequencer_edit.c

Loading...

source/blender/makesrna/intern/rna_sequencer.c

Loading...

source/blender/makesrna/intern/rna_sequencer_api.c

Loading...

source/blender/sequencer/SEQ_relations.h

Loading...

source/blender/sequencer/SEQ_time.h

Loading...

source/blender/sequencer/intern/strip_add.c

Loading...

source/blender/sequencer/intern/strip_relations.c

Loading...

source/blender/sequencer/intern/strip_time.c

Loading...