Page MenuHome
Differential D13105

Nodes: Add preview image to node group.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 4 2021, 12:04 PM.

Details

Reviewers
Julian Eisel (Severin)
Commits
rBf315a4698208: Nodes: add preview image storage to node group
Summary

This is doing the same that was done in rB2397ccc583af: Animation: Add PreviewImage to bAction struct, just for bNodeTree.
This is in preparation for T92811.

Diff Detail

Repository
rB Blender
Branch
node-group-previews (branched from master)
Build Status
Buildable 18510
Build 18510: arc lint + arc unit

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 4 2021, 12:04 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18463: Diff 44353.Nov 4 2021, 12:04 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 4 2021, 12:05 PM
Jacques Lucke (JacquesLucke) added a reviewer: Julian Eisel (Severin).
Julian Eisel (Severin) requested changes to this revision.Nov 5 2021, 12:10 PM

This will need the same fix as done in rBfa96aa581192. Looks good besides that!

This revision now requires changes to proceed.Nov 5 2021, 12:10 PM
Julian Eisel (Severin) added a comment.Nov 5 2021, 12:11 PM

Also: I'd try to make clear in the title that this isn't automatic preview support for node groups. E.g. "Nodes: Add preview image storage to node group"?

Jacques Lucke (JacquesLucke) updated this revision to Diff 44427.Nov 5 2021, 4:00 PM
  • Merge branch 'master' into node-group-previews
  • fix

Am I missing something or is BLO_blendhandle_get_previews not used at all?o

Harbormaster completed remote builds in B18510: Diff 44427.Nov 5 2021, 4:00 PM
Julian Eisel (Severin) accepted this revision.Nov 5 2021, 6:10 PM
In D13105#346385, @Jacques Lucke (JacquesLucke) wrote:

Am I missing something or is BLO_blendhandle_get_previews not used at all?o

Indeed, we don't seem to use it anymore after rB0fd1e6a5f43df8.

This revision is now accepted and ready to land.Nov 5 2021, 6:10 PM
Closed by commit rBf315a4698208: Nodes: add preview image storage to node group (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 6 2021, 4:46 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBf315a4698208: Nodes: add preview image storage to node group.

Revision Contents
Changeset List

PathSize
source/
blender/
blenkernel/
intern/
2 lines
15 lines
blenloader/
intern/
1 line
makesdna/
4 lines

Diff 44427

View Options

source/blender/blenkernel/intern/icons.cc

Loading...
View Options

source/blender/blenkernel/intern/node.cc

Loading...
View Options

source/blender/blenloader/intern/readblenentry.c

Loading...
View Options

source/blender/makesdna/DNA_node_types.h

Loading...