Page MenuHome
Differential D13108

Nodes: Add default link socket to socket declaration.
ClosedPublic
Actions

Authored by Jacques Lucke (JacquesLucke) on Nov 4 2021, 12:53 PM.

Details

Reviewers
Hans Goudey (HooglyBoogly)
Maniphest Tasks
T92814: Fix auto-linkage in Float Curve node
Commits
rBbe4478d1f8b6: Fix T92814: improve automatic linking when inserting Float Curve node
Summary

This fixes T92814 in a more general way. Hopefully we can get rid of the heuristic for socket selection at some point, but that's not something I'd do for 3.0.

Nodes can now specify which sockets should be linked when the node is dropped on an existing link. We could make this more specific in the future (e.g. having a default socket per type etc), but that's not necessary for now.

Diff Detail

Repository
rB Blender

Event Timeline

Jacques Lucke (JacquesLucke) requested review of this revision.Nov 4 2021, 12:53 PM
Jacques Lucke (JacquesLucke) created this revision.
Harbormaster completed remote builds in B18466: Diff 44356.Nov 4 2021, 12:53 PM
Jacques Lucke (JacquesLucke) added a task: T92814: Fix auto-linkage in Float Curve node.Nov 4 2021, 12:53 PM
Jacques Lucke (JacquesLucke) edited the summary of this revision. (Show Details)Nov 4 2021, 12:56 PM
Jacques Lucke (JacquesLucke) added a reviewer: Hans Goudey (HooglyBoogly).
Jacques Lucke (JacquesLucke) updated this revision to Diff 44359.Nov 4 2021, 12:57 PM
  • cleanup
Harbormaster completed remote builds in B18469: Diff 44359.Nov 4 2021, 12:57 PM
Hans Goudey (HooglyBoogly) added inline comments.Nov 4 2021, 1:53 PM
source/blender/editors/space_node/node_relationships.cc
2203

Could this check the type too? It seems reasonable to only use the default where the types match.

Jacques Lucke (JacquesLucke) added inline comments.Nov 4 2021, 2:34 PM
source/blender/editors/space_node/node_relationships.cc
2203

Types don't have to match exactly in general. We could check for convertability, but that can be fixed as part of T91840.

Hans Goudey (HooglyBoogly) accepted this revision.Nov 4 2021, 2:37 PM
Hans Goudey (HooglyBoogly) added inline comments.
source/blender/editors/space_node/node_relationships.cc
2203

Okay, as long as we have a task for it, works for me.

This revision is now accepted and ready to land.Nov 4 2021, 2:37 PM
Closed by commit rBbe4478d1f8b6: Fix T92814: improve automatic linking when inserting Float Curve node (authored by Jacques Lucke (JacquesLucke)). · Explain WhyNov 4 2021, 2:45 PM
This revision was automatically updated to reflect the committed changes.
Jacques Lucke (JacquesLucke) added a commit: rBbe4478d1f8b6: Fix T92814: improve automatic linking when inserting Float Curve node.
Charlie Jolly (charlie) awarded a token.Nov 4 2021, 2:49 PM

Revision Contents
Changeset List

PathSize
source/
blender/
editors/
space_node/
32 lines
nodes/
13 lines
shader/
nodes/
2 lines

Diff 44366

View Options

source/blender/editors/space_node/node_relationships.cc

Loading...
View Options

source/blender/nodes/NOD_node_declaration.hh

Loading...
View Options

source/blender/nodes/shader/nodes/node_shader_curves.cc

Loading...