UI: Add frame range theme options
Needs ReviewPublic
Actions

Authored by RedMser (RedMser) on Nov 4 2021, 8:03 PM.

Details

Reviewers

Hans Goudey (HooglyBoogly)
Pablo Vazquez (pablovazquez)

Summary

UI: Add frame range theme options

Allow changing theme colors for the start/end frame range
overlay, similar to changing the preview range colors.

Affects dopesheet, graph, timeline, movie clip (graph/dopesheet)
and sequencer editor.

I tried working on a high contrast theme for Blender, which uses a fully black (#000000) background extensively.
You could not see the scene's start/end frame ranges, due to the hardcoded shading values.

Diff Detail

Repository

rB Blender

Branch

frame-range-theme (branched from master)

Build Status

Buildable 18482
Build 18482: arc lint + arc unit

Event Timeline

RedMser (RedMser) requested review of this revision.Nov 4 2021, 8:03 PM

RedMser (RedMser) created this revision.

Harbormaster completed remote builds in B18482: Diff 44379.Nov 4 2021, 8:03 PM

Thanks for the patch. @Pablo Vazquez (pablovazquez) knows much more about using the theme than me, and should have a better idea about this solution. It seems sensible to me, but usually we'd try to see if another theme color could be reused before adding a new one.

In D13116#347748, @Hans Goudey (HooglyBoogly) wrote:

Thanks for the patch. @Pablo Vazquez (pablovazquez) knows much more about using the theme than me, and should have a better idea about this solution. It seems sensible to me, but usually we'd try to see if another theme color could be reused before adding a new one.

I think this one makes sense to have. It would be great if we had a global setting for all editors but since there is one already for Preview Range, it makes sense to have one for this.

One note, aren't the name and tooltip misleading though? Since it's actually the opposite of Time Range, although since we already have Preview Range maybe that's okay.

For the tooltip:
"Color of frame start/end range overlay" -> "Color of the background when out of frame start/end range" or so.

Also, it's probably better placed next to Preview Range since it's a similar concept.