Page MenuHome
Differential D13117

Fix Kernels loading on Arch names with extra options
ClosedPublic
Actions

Authored by Brian Savery (bsavery) on Nov 4 2021, 8:10 PM.

Details

Reviewers
Brecht Van Lommel (brecht)
Maniphest Tasks
T92836: Fix Kernels loading on Arch names with extra options
Commits
rC50de1cd3141a: Fix Cycles HIP Kernels loading on Arch names with extra options
rB36f5198282d3: Fix Cycles HIP Kernels loading on Arch names with extra options
Summary

The kernel file names are search for based on the arch name, for example gfx1010. However HIP's gcnArchName can contain options such as xnack- in the name. For example gfx1010:sramecc-:xnack-

This revision tokenizes the info from gcnArchName and just uses the first token for choosing the Kernel file to use. Kernels are portable across those features in the arch name,

Also I removed the bit for recompiling ptx as clearly that is not relevant.

Diff Detail

Repository
rB Blender

Event Timeline

Brian Savery (bsavery) requested review of this revision.Nov 4 2021, 8:10 PM
Brian Savery (bsavery) created this revision.
Brian Savery (bsavery) edited the summary of this revision. (Show Details)
Brecht Van Lommel (brecht) accepted this revision.Nov 4 2021, 8:15 PM
This revision is now accepted and ready to land.Nov 4 2021, 8:15 PM
Brecht Van Lommel (brecht) added a comment.Nov 4 2021, 8:26 PM

I will modify this to also handle the runtime compilation case.

Closed by commit rB36f5198282d3: Fix Cycles HIP Kernels loading on Arch names with extra options (authored by Brian Savery (bsavery), committed by Brecht Van Lommel (brecht)). · Explain WhyNov 4 2021, 8:27 PM
This revision was automatically updated to reflect the committed changes.
Brecht Van Lommel (brecht) added a commit: rB36f5198282d3: Fix Cycles HIP Kernels loading on Arch names with extra options.
Brecht Van Lommel (brecht) added a task: T92836: Fix Kernels loading on Arch names with extra options.Nov 4 2021, 8:28 PM
Ray Molenkamp (LazyDodo) added a subscriber: Ray Molenkamp (LazyDodo).Nov 4 2021, 8:29 PM
Ray Molenkamp (LazyDodo) added inline comments.
intern/cycles/device/hip/device_impl.cpp
244

ther->the

Ray Molenkamp (LazyDodo) added a comment.Nov 4 2021, 8:29 PM

ow wow, already too late, that was fast :)

Brecht Van Lommel (brecht) added a comment.Nov 4 2021, 8:37 PM

I've fixed the typo in a follow up commit now.

Brecht Van Lommel (brecht) added a commit: rC50de1cd3141a: Fix Cycles HIP Kernels loading on Arch names with extra options.Jan 27 2022, 11:31 PM

Revision Contents
Changeset List

PathSize
intern/
cycles/
device/
hip/
35 lines

Diff 44383

View Options

intern/cycles/device/hip/device_impl.cpp

Loading...