Differential D13122

Cleanup: Correct order of guard and lock in moviecache_valfree
ClosedPublic
Actions

Authored by Jesse Yurkovich (deadpin) on Nov 5 2021, 6:13 AM.

Tags

None

Subscribers

None

Details

Reviewers

Ray Molenkamp (LazyDodo)
Hans Goudey (HooglyBoogly)

Commits

rB0564b19ff4dd: Cleanup: Correct order of guard and lock in moviecache_valfree
rBe8a8bb67fcef: Cleanup: Correct order of guard and lock in moviecache_valfree

Summary

Fix own mistake in rB7061d1e39fe

In my attempt to quickly address T92838, along with the original bug, I
made a nonsensical choice to use the limiter lock to guard the check
against the cache item itself. While harmless, it is not necessary and
semantically wrong / potentially confusing to future readers of the code.

Diff Detail

Repository: rB Blender

Event Timeline

Jesse Yurkovich (deadpin) requested review of this revision.Nov 5 2021, 6:13 AM

Jesse Yurkovich (deadpin) created this revision.

Harbormaster completed remote builds in B18493: Diff 44401.Nov 5 2021, 6:13 AM

Jesse Yurkovich (deadpin) added reviewers: Ray Molenkamp (LazyDodo), Hans Goudey (HooglyBoogly).Nov 5 2021, 6:16 AM

Reading the conversation in the report, I think this is fine to just commit. The logic is obvious too, unless I'm crazy.

This revision is now accepted and ready to land.Nov 10 2021, 9:25 PM

whoops, let this one slip through the cracks, sorry!

Closed by commit rBe8a8bb67fcef: Cleanup: Correct order of guard and lock in moviecache_valfree (authored by Jesse Yurkovich (deadpin)). · Explain WhyNov 13 2021, 6:46 AM

This revision was automatically updated to reflect the committed changes.

Jesse Yurkovich (deadpin) added a commit: rBe8a8bb67fcef: Cleanup: Correct order of guard and lock in moviecache_valfree.

Evan Wilson (EAW) mentioned this in T93935: Blender 3.0 Motion tracking footage just crashes blender.Dec 16 2021, 3:07 AM

Philipp Oeser (lichtwerk) added a commit: rB0564b19ff4dd: Cleanup: Correct order of guard and lock in moviecache_valfree.Jan 11 2022, 9:33 AM

Revision Contents
Changeset List

Path

Size

source/

blender/

imbuf/

intern/

4 lines

Diff 44713

source/blender/imbuf/intern/moviecache.c

Loading...