Details

Reviewers

Commits

rBS38940662e540: Particle Info node support for GLSL mode and the internal render.
rB38940662e540: Particle Info node support for GLSL mode and the internal render.

Summary

With this patch "Particle Info" node from Cycles works in GLSL and BI.

Alexander (Blend4Web Team)

Diff Detail

Repository: rB Blender

Event Timeline

Alexander Romanov (a.romanov) updated this revision to Diff 4266.May 20 2015, 2:42 PM

Alexander Romanov (a.romanov) retitled this revision from to Particle Info node support for GLSL mode and the internal render..

Alexander Romanov (a.romanov) updated this object.

Alexander Romanov (a.romanov) added a reviewer: Antonis Ryakiotakis (psy-fi).

Alexander Romanov (a.romanov) added subscribers: Evgeny_Rodygin, Yuri Kovelenov (yurikovelenov), Alexander Kovelenov (AlexKowel), Dontsov Valentin (valentin_b4w).

Thomas Beck (plasmasolutions) added a subscriber: Thomas Beck (plasmasolutions).May 20 2015, 4:13 PM

Pretty nice! At some point we should separate material variable initialization from object variable initialization. This will help us passing objects and duplis around like that, but this can always be done later as a cleanup. From quick glance patch looks OK, will take a more in depth look before merging, right after release.

Lapineige added a subscriber: Lapineige.May 20 2015, 7:19 PM

Duarte Farrajota Ramos (duarteframos) added a subscriber: Duarte Farrajota Ramos (duarteframos).May 21 2015, 7:10 AM

BGE player build fix

There are some changes needed before further review is done. The patch can be greatly simplified by not passing DupliObjects around.

source/blender/editors/space_view3d/drawmesh.c
1080 ↗	(On Diff #4270)	Passing the dupliobject around is quite ugly. I would add functions like GPU_begin_dupliobject / GPU_end_dupliobject that set/unset the global material dupli object around the call where the dupli is drawn.
source/blender/editors/space_view3d/view3d_draw.c
2178	This will fail. Display list will get called with the options used at compilation time so if particle attributes change, this won't be reflected on the instance. Also lists are not used for what you want (GLSL). Check code above to see why (use_displist disabled in that case)
2194	Due to GLSL (check above), lists are never used. This is the place where you can add the GPU_begin_dupliobject / GPU_end_dupliobject calls mentioned above.
source/blender/render/intern/source/shadeinput.c
1325	No need for this, shaderinput.c has access to R, check extern struct Render R;

Antonis Ryakiotakis (psy-fi) requested changes to this revision.Jul 13 2015, 3:21 PM

Antonis Ryakiotakis (psy-fi) edited edge metadata.

This revision now requires changes to proceed.Jul 13 2015, 3:21 PM

Fixed dupliobject passing and other inaccuracies

Fill particle info parameters of shader input in separate function

Closed by commit rB38940662e540: Particle Info node support for GLSL mode and the internal render. (authored by Alexander Romanov (a.romanov), committed by Antonis Ryakiotakis (psy-fi)). · Explain WhyJul 14 2015, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Raoni Gillet Hensill (Ra_one) awarded a token.Jul 16 2015, 1:55 AM

Supported in Blend4Web since 16.02 release: https://www.blend4web.com/en/article/186/

Particle Info node support for GLSL mode and the internal render.
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 4654

release/scripts/startup/nodeitems_builtins.py

source/blender/editors/space_view3d/view3d_draw.c

source/blender/gpu/GPU_draw.h

source/blender/gpu/GPU_material.h

source/blender/gpu/intern/gpu_codegen.c

source/blender/gpu/intern/gpu_draw.c

source/blender/gpu/intern/gpu_material.c

source/blender/gpu/shaders/gpu_shader_material.glsl

source/blender/nodes/shader/nodes/node_shader_particle_info.c

source/blender/render/extern/include/RE_shader_ext.h

source/blender/render/intern/include/render_types.h

source/blender/render/intern/source/renderdatabase.c

source/blender/render/intern/source/shadeinput.c

source/blenderplayer/bad_level_call_stubs/stubs.c

source/gameengine/Ketsji/BL_BlenderShader.cpp

Particle Info node support for GLSL mode and the internal render.ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 4654

release/scripts/startup/nodeitems_builtins.py

source/blender/editors/space_view3d/view3d_draw.c

source/blender/gpu/GPU_draw.h

source/blender/gpu/GPU_material.h

source/blender/gpu/intern/gpu_codegen.c

source/blender/gpu/intern/gpu_draw.c

source/blender/gpu/intern/gpu_material.c

source/blender/gpu/shaders/gpu_shader_material.glsl

source/blender/nodes/shader/nodes/node_shader_particle_info.c

source/blender/render/extern/include/RE_shader_ext.h

source/blender/render/intern/include/render_types.h

source/blender/render/intern/source/renderdatabase.c

source/blender/render/intern/source/shadeinput.c

source/blenderplayer/bad_level_call_stubs/stubs.c

source/gameengine/Ketsji/BL_BlenderShader.cpp

Particle Info node support for GLSL mode and the internal render.
ClosedPublic
Actions

Revision Contents
Changeset List