Cleanup: Remove `SMALL_TRI_RIGHT_VEC` icon
ClosedPublic
Actions

Authored by Pablo Vazquez (pablovazquez) on Nov 5 2021, 6:45 PM.

Details

Reviewers

Julian Eisel (Severin)

Commits

rB368d7944073e: Cleanup: Remove `SMALL_TRI_RIGHT_VEC` icon

Summary

Since the recent change to context paths to use the arrow icon instead of the triangle (D13106),
the SMALL_TRI_RIGHT_VECis no longer used. This patch removes the icon and all references.

Replace SMALL_TRI_RIGHT_VEC with RIGHTARROW in Freestyle UI
Remove references to SMALL_TRI_RIGHT_VEC and ICON_SMALL_TRI_RIGHT_VEC.

Fix for built-in add-ons has been done in rBAcc2f71bfe9b0/rBAa84028f8a89a.

This will be added to the list of breaking changes in the Wiki.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Vazquez (pablovazquez) requested review of this revision.Nov 5 2021, 6:45 PM

Pablo Vazquez (pablovazquez) created this revision.

Harbormaster completed remote builds in B18515: Diff 44436.Nov 5 2021, 6:45 PM

Pablo Vazquez (pablovazquez) added a reviewer: Julian Eisel (Severin).Nov 5 2021, 6:49 PM

You're planning to commit his to the release branch, right?

The Stored Views add-on still uses the icon, we better update that as well or let the author know. And should be added to the release notes https://wiki.blender.org/wiki/Reference/Release_Notes/3.0/Python_API#Breaking_Changes.

This revision is now accepted and ready to land.Nov 8 2021, 10:32 AM

In D13130#346789, @Julian Eisel (Severin) wrote:

You're planning to commit his to the release branch, right?

Yes, since it's a breaking change I think it's better to do it in 3.0.

The Stored Views add-on still uses the icon, we better update that as well or let the author know.

~~Yes I've seen that. I didn't know how to properly add a commit from a submodule to this same patch, but I'll do right after this is committed. I checked with one of the authors already (Francesco).~~ Committed to rBAa84028.